diff options
| author | Friedemann Kleint <Friedemann.Kleint@qt.io> | 2018-08-31 10:27:37 +0200 |
|---|---|---|
| committer | Friedemann Kleint <Friedemann.Kleint@qt.io> | 2018-08-31 10:12:06 +0000 |
| commit | d0ef246be94375b247ec667d867d6978d513ddeb (patch) | |
| tree | 00aa28e4e729e5fd29f5d8da38b59607f4cbe2dc /sources/pyside2/libpyside/dynamicqmetaobject.h | |
| parent | 4af51767cf8514b196ce9be76c6c31111ea5fe3f (diff) | |
libpyside: Fix clang-tidy warnings about class definitions
- Add override
- Use = default for trivial constructors/destructors
- Add Q_DISABLE_COPY where applicable
- Use member initialization and remove constructors from simple structs
- Use explicit where applicable (which requires adapting code snippets
constructing a QVariant from PyObjectWrapper)
- Fix some parameter to take a const ref or pass by value
and use std::move in constructors
Change-Id: I5e0d2c4ef92d20397a7daba2f8a64b507e678510
Reviewed-by: Christian Tismer <tismer@stackless.com>
Diffstat (limited to 'sources/pyside2/libpyside/dynamicqmetaobject.h')
| -rw-r--r-- | sources/pyside2/libpyside/dynamicqmetaobject.h | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/sources/pyside2/libpyside/dynamicqmetaobject.h b/sources/pyside2/libpyside/dynamicqmetaobject.h index 5ecce50c9..58fe84ffc 100644 --- a/sources/pyside2/libpyside/dynamicqmetaobject.h +++ b/sources/pyside2/libpyside/dynamicqmetaobject.h @@ -50,6 +50,7 @@ namespace PySide class DynamicQMetaObject : public QMetaObject { + Q_DISABLE_COPY(DynamicQMetaObject) public: DynamicQMetaObject(const char* className, const QMetaObject* metaObject); DynamicQMetaObject(PyTypeObject* type, const QMetaObject* metaobject); @@ -62,7 +63,7 @@ public: int addSlot(const char* slot, const char* type = 0); int addProperty(const char* property, PyObject* data); void addInfo(const char* key, const char* value); - void addInfo(QMap<QByteArray, QByteArray> info); + void addInfo(const QMap<QByteArray, QByteArray> &info); void removeSignal(uint idex); void removeSlot(uint index); |