diff options
| author | Friedemann Kleint <Friedemann.Kleint@qt.io> | 2018-08-31 10:27:37 +0200 |
|---|---|---|
| committer | Friedemann Kleint <Friedemann.Kleint@qt.io> | 2018-08-31 10:12:06 +0000 |
| commit | d0ef246be94375b247ec667d867d6978d513ddeb (patch) | |
| tree | 00aa28e4e729e5fd29f5d8da38b59607f4cbe2dc /sources/pyside2/libpyside/globalreceiver.h | |
| parent | 4af51767cf8514b196ce9be76c6c31111ea5fe3f (diff) | |
libpyside: Fix clang-tidy warnings about class definitions
- Add override
- Use = default for trivial constructors/destructors
- Add Q_DISABLE_COPY where applicable
- Use member initialization and remove constructors from simple structs
- Use explicit where applicable (which requires adapting code snippets
constructing a QVariant from PyObjectWrapper)
- Fix some parameter to take a const ref or pass by value
and use std::move in constructors
Change-Id: I5e0d2c4ef92d20397a7daba2f8a64b507e678510
Reviewed-by: Christian Tismer <tismer@stackless.com>
Diffstat (limited to 'sources/pyside2/libpyside/globalreceiver.h')
| -rw-r--r-- | sources/pyside2/libpyside/globalreceiver.h | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/sources/pyside2/libpyside/globalreceiver.h b/sources/pyside2/libpyside/globalreceiver.h index 426d40bfe..8fbe2fe78 100644 --- a/sources/pyside2/libpyside/globalreceiver.h +++ b/sources/pyside2/libpyside/globalreceiver.h @@ -55,9 +55,10 @@ class GlobalReceiver : public QObject { public: GlobalReceiver(); - ~GlobalReceiver(); - int qt_metacall(QMetaObject::Call call, int id, void** args); - const QMetaObject* metaObject() const; + ~GlobalReceiver() override; + + int qt_metacall(QMetaObject::Call call, int id, void** args) override; + const QMetaObject* metaObject() const override; int addSlot(const char* slot, PyObject* callback); void removeSlot(int slotId); void connectNotify(QObject* sender, int slotId); |