diff options
| author | Christian Tismer <tismer@stackless.com> | 2022-06-21 10:22:04 +0200 |
|---|---|---|
| committer | Christian Tismer <tismer@stackless.com> | 2022-07-11 14:42:45 +0000 |
| commit | 2720e01f21f3771cb755ef183b8160f691bdb575 (patch) | |
| tree | e68bfc45e6797401604423aaff6ab791f9fc01d0 /sources/pyside6/libpyside/pysidesignal.cpp | |
| parent | 52d38437445f6aa979875a93702496f800b98d63 (diff) | |
Shiboken: Fix the oldest shiboken bug ever which shows up on Python 3.11
b7df2f1c0 "Fix signal initializer.", 18. May 2010 at 00:55
There was a `PySequence_Check` in the evaluation of some signature
function parameter processing, which should have been `PyTuple_Check`.
Since the new PyEnums are also sequences, the new optimization in
Python 3.11 changed the parameter handling in a correct way and
replaced the argument tuple by a direct single argument of an enum
type. And that is also a sequence ...
There are probably still dormant issues like this in the codebase
which gives reason to submit a task that checks all Python interface
functions for correctness.
Change-Id: I45996a0458c3e60795d2eb802eb98f7dd3678d92
Pick-to: 6.3
Task-number: PYSIDE-1735
Task-number: PYSIDE-1987
Fixes: PYSIDE-1988
Reviewed-by: Cristian Maureira-Fredes <cristian.maureira-fredes@qt.io>
Reviewed-by: Shyamnath Premnadh <Shyamnath.Premnadh@qt.io>
Diffstat (limited to 'sources/pyside6/libpyside/pysidesignal.cpp')
| -rw-r--r-- | sources/pyside6/libpyside/pysidesignal.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/sources/pyside6/libpyside/pysidesignal.cpp b/sources/pyside6/libpyside/pysidesignal.cpp index b1515cb05..90332a7dd 100644 --- a/sources/pyside6/libpyside/pysidesignal.cpp +++ b/sources/pyside6/libpyside/pysidesignal.cpp @@ -881,7 +881,7 @@ static QByteArray buildSignature(const QByteArray &name, const QByteArray &signa static QByteArray parseSignature(PyObject *args) { - if (args && (Shiboken::String::check(args) || !PySequence_Check(args))) + if (args && (Shiboken::String::check(args) || !PyTuple_Check(args))) return getTypeName(args); QByteArray signature; |