diff options
| author | Friedemann Kleint <Friedemann.Kleint@qt.io> | 2023-09-18 10:11:13 +0200 |
|---|---|---|
| committer | Friedemann Kleint <Friedemann.Kleint@qt.io> | 2023-09-20 13:44:47 +0200 |
| commit | b8f5e535dab255af228830c6d548ce730a7603d5 (patch) | |
| tree | 82fe89344b91a4bf82180efff9734dc3429ef4cc /sources/pyside6/libpyside/pysidesignal.cpp | |
| parent | 2cc7ded80caa506263ba2c9fd87db76dae71956a (diff) | |
libshiboken/libpyside: Fix some static analysis warnings
- nullptr
- narrowing integer conversions
- else after return
- Use auto
- Missing move special functions
Pick-to: 6.6 6.5
Change-Id: Ib872481a46c8bb17592cdc1778ab3c4d9598c753
Reviewed-by: Shyamnath Premnadh <Shyamnath.Premnadh@qt.io>
Diffstat (limited to 'sources/pyside6/libpyside/pysidesignal.cpp')
| -rw-r--r-- | sources/pyside6/libpyside/pysidesignal.cpp | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/sources/pyside6/libpyside/pysidesignal.cpp b/sources/pyside6/libpyside/pysidesignal.cpp index 9172a0c45..92ce69b13 100644 --- a/sources/pyside6/libpyside/pysidesignal.cpp +++ b/sources/pyside6/libpyside/pysidesignal.cpp @@ -789,9 +789,9 @@ static PyObject *_getHomonymousMethod(PySideSignalInstance *inst) auto signalName = inst->d->signalName; Shiboken::AutoDecRef name(Shiboken::String::fromCString(signalName)); auto *mro = Py_TYPE(inst->d->source)->tp_mro; - Py_ssize_t idx, n = PyTuple_GET_SIZE(mro); + const Py_ssize_t n = PyTuple_GET_SIZE(mro); - for (idx = 0; idx < n; idx++) { + for (Py_ssize_t idx = 0; idx < n; idx++) { auto *sub_type = reinterpret_cast<PyTypeObject *>(PyTuple_GET_ITEM(mro, idx)); auto *hom = PyDict_GetItem(sub_type->tp_dict, name); PyObject *realFunc{}; |