diff options
| author | Friedemann Kleint <Friedemann.Kleint@qt.io> | 2022-12-19 14:09:23 +0100 |
|---|---|---|
| committer | Friedemann Kleint <Friedemann.Kleint@qt.io> | 2022-12-22 09:30:08 +0100 |
| commit | 1930ac417cc24ed74842e1a6f1c751ce2cfc47d0 (patch) | |
| tree | 78387dc7d565b1124a874c13074d929022be69aa /sources/shiboken6/tests/libsample/expression.cpp | |
| parent | 8cc5d64cf80f918b75366e148c7a951404b2313b (diff) | |
Fix coding style of the shiboken tests
- Place star/reference correctly
- Fix include order
- Streamline code, wrap long lines
- Use member initialization and default special methods
Change-Id: I7b7e7d8e8c9562cd932bee8144bc44d6b2dda0a5
Reviewed-by: Shyamnath Premnadh <Shyamnath.Premnadh@qt.io>
Reviewed-by: Adrian Herrmann <adrian.herrmann@qt.io>
Reviewed-by: Christian Tismer <tismer@stackless.com>
Diffstat (limited to 'sources/shiboken6/tests/libsample/expression.cpp')
| -rw-r--r-- | sources/shiboken6/tests/libsample/expression.cpp | 20 |
1 files changed, 9 insertions, 11 deletions
diff --git a/sources/shiboken6/tests/libsample/expression.cpp b/sources/shiboken6/tests/libsample/expression.cpp index 21a51a288..5a6b4f4bb 100644 --- a/sources/shiboken6/tests/libsample/expression.cpp +++ b/sources/shiboken6/tests/libsample/expression.cpp @@ -3,17 +3,16 @@ #include "expression.h" + #include <sstream> -Expression::Expression() : m_value(0), m_operation(None), m_operand1(nullptr), m_operand2(nullptr) -{ -} +Expression::Expression() = default; -Expression::Expression(int number) : m_value(number), m_operation(None), m_operand1(nullptr), m_operand2(nullptr) +Expression::Expression(int number) : m_value(number) { } -Expression::Expression(const Expression& other) +Expression::Expression(const Expression &other) { m_operand1 = other.m_operand1 ? new Expression(*other.m_operand1) : nullptr; m_operand2 = other.m_operand2 ? new Expression(*other.m_operand2) : nullptr; @@ -21,7 +20,7 @@ Expression::Expression(const Expression& other) m_operation = other.m_operation; } -Expression& Expression::operator=(const Expression& other) +Expression &Expression::operator=(const Expression &other) { if (&other == this) return *this; @@ -40,7 +39,7 @@ Expression::~Expression() delete m_operand2; } -Expression Expression::operator+(const Expression& other) +Expression Expression::operator+(const Expression &other) { Expression expr; expr.m_operation = Add; @@ -49,7 +48,7 @@ Expression Expression::operator+(const Expression& other) return expr; } -Expression Expression::operator-(const Expression& other) +Expression Expression::operator-(const Expression &other) { Expression expr; expr.m_operation = Add; @@ -58,7 +57,7 @@ Expression Expression::operator-(const Expression& other) return expr; } -Expression Expression::operator<(const Expression& other) +Expression Expression::operator<(const Expression &other) { Expression expr; expr.m_operation = LessThan; @@ -67,7 +66,7 @@ Expression Expression::operator<(const Expression& other) return expr; } -Expression Expression::operator>(const Expression& other) +Expression Expression::operator>(const Expression &other) { Expression expr; expr.m_operation = GreaterThan; @@ -111,4 +110,3 @@ std::string Expression::toString() const result += ')'; return result; } - |