diff options
| author | Ivan Solovev <ivan.solovev@qt.io> | 2024-02-08 17:19:26 +0100 |
|---|---|---|
| committer | Ivan Solovev <ivan.solovev@qt.io> | 2024-02-12 23:49:54 +0100 |
| commit | 612b67cf13cedb832e082308b620f948377ddf21 (patch) | |
| tree | 8d636fbfeb8a2873d807239d63199e630c8863a1 /src/corelib/serialization/qdatastream.cpp | |
| parent | 9f66c9396f2dfd96e8b73ae34c75f168254d7bd6 (diff) | |
QTimer: do not set active state when setting a negative interval
QObject::startTimer() returns 0 in case of failure, for example when
someone tries to register a timer with a negative interval.
However, QTimer internally uses -1 as an invalid timer id.
This could lead to a situation when the timer was not really started,
but QTimer::isActive() returned true.
This patch fixes it in two ways:
- check the return value of QObject::startTimer() and treat 0 as an
error.
- do not treat 0 as a valid timer id when calculating the active state.
As a drive-by: move the `using namespace std::chrono_literals;`
declaration to the top of tst_qtimer.cpp, so that we do not need to
repeat it in each test case.
Fixes: QTBUG-122087
Pick-to: 6.7 6.6 6.5
Change-Id: I0e21152b2173ebb5fb0dada1b99a903a321ca9c4
Reviewed-by: Ahmad Samir <a.samirh78@gmail.com>
Diffstat (limited to 'src/corelib/serialization/qdatastream.cpp')
0 files changed, 0 insertions, 0 deletions