Return to Answer

Yes, it's a smell: Hard-to-Test Code

I'd start with the following:

1. Create an interface for MyApiClient (usually it's easier to mock interfaces than classes),
2. Remove the static modifier of signin,
3. Create a constructor in Sign which get a MyApiClient instance and store it in a field,
4. Modify the signin method to use the instance above.

public class Sign {

    private final MyApiClient client;

    public Sign(final MyApiClient client) {
        this.client = client;
    }

    public void signin(final String username, final String password, 
            final SigninResponseHandler responseHandler) {
        ...
        client.post(path, params, ...

Here you can create a Sign object with a mocked MyApiClient which is easier to test.

Some other notes:

1. Sign does not seem a good class name. From Clean Code, page 25:

   Classes and objects should have noun or noun phrase names like Customer, WikiPage, Account, and AddressParser. [...] A class name should not be a verb.

2. MyApiClient also should be renamed something meaningful.

Some useful readings:

• Eliminating static helper classes
• TotT: Using Dependency Injection to Avoid Singletons
• Effective Java, Second Edition, Item 16: Favor composition over inheritance.

Yes, it's a smell: Hard-to-Test Code

I'd start with the following:

1. Create an interface for MyApiClient (usually it's easier to mock interfaces than classes),
2. Remove the static modifier of signin,
3. Create a constructor in Sign which get a MyApiClient instance and store it in a field,
4. Modify the signin method to use the instance above.

public class Sign {

    private final MyApiClient client;

    public Sign(final MyApiClient client) {
        this.client = client;
    }

    public void signin(final String username, final String password, 
            final SigninResponseHandler responseHandler) {
        ...
        client.post(path, params, ...

Here you can create a Sign object with a mocked MyApiClient which is easier to test.

Some other notes:

1. Sign does not seem a good class name. From Clean Code, page 25:

   Classes and objects should have noun or noun phrase names like Customer, WikiPage, Account, and AddressParser. [...] A class name should not be a verb.

2. MyApiClient also should be renamed something meaningful.

Some useful readings:

• Eliminating static helper classes
• TotT: Using Dependency Injection to Avoid Singletons
• Effective Java, Second Edition, Item 16: Favor composition over inheritance.

Yes, it's a smell: Hard-to-Test Code

I'd start with the following:

1. Create an interface for MyApiClient,
2. Remove the static modifier of signin,
3. Create a constructor in Sign which get a MyApiClient instance and store it in a field,
4. Modify the signin method to use the instance above.

public class Sign {

    private final MyApiClient client;

    public Sign(final MyApiClient client) {
        this.client = client;
    }

    public void signin(final String username, final String password, 
            final SigninResponseHandler responseHandler) {
        ...
        client.post(path, params, ...

Here you can create a Sign object with a mocked MyApiClient which is easier to test.

Some other notes:

1. Sign does not seem a good class name. From Clean Code, page 25:

   Classes and objects should have noun or noun phrase names like Customer, WikiPage, Account, and AddressParser. [...] A class name should not be a verb.

2. MyApiClient also should be renamed something meaningful.

Two useful readings:

• Eliminating static helper classes
• TotT: Using Dependency Injection to Avoid Singletons

Yes, it's a smell: Hard-to-Test Code

I'd start with the following:

1. Create an interface for MyApiClient (usually it's easier to mock interfaces than classes),
2. Remove the static modifier of signin,
3. Create a constructor in Sign which get a MyApiClient instance and store it in a field,
4. Modify the signin method to use the instance above.

public class Sign {

    private final MyApiClient client;

    public Sign(final MyApiClient client) {
        this.client = client;
    }

    public void signin(final String username, final String password, 
            final SigninResponseHandler responseHandler) {
        ...
        client.post(path, params, ...

Here you can create a Sign object with a mocked MyApiClient which is easier to test.

Some other notes:

1. Sign does not seem a good class name. From Clean Code, page 25:

   Classes and objects should have noun or noun phrase names like Customer, WikiPage, Account, and AddressParser. [...] A class name should not be a verb.

2. MyApiClient also should be renamed something meaningful.

Some useful readings:

• Eliminating static helper classes
• TotT: Using Dependency Injection to Avoid Singletons
• Effective Java, Second Edition, Item 16: Favor composition over inheritance.

Yes, it's a smell: Hard-to-Test Code

I'd start with the following:

1. Create an interface for MyApiClient,
2. Remove the static modifier of siging,
3. Create a constructor in Sign which get a MyApiClient instance and store it in a field,
4. Modify the signin method to use the instance above.

public class Sign {

    private final MyApiClient client;

    public Sign(final MyApiClient client) {
        this.client = client;
    }

    public void signin(final String username, final String password, 
            final SigninResponseHandler responseHandler) {
        ...
        client.post(path, params, ...

Here you can create a Sign object with a mocked MyApiClient which is easier to test.

Some other notes:

1. Sign does not seem a good class name. From Clean Code, page 25:

   Classes and objects should have noun or noun phrase names like Customer, WikiPage, Account, and AddressParser. [...] A class name should not be a verb.

2. MyApiClient also should be renamed something meaningful.

Two useful readings:

• Eliminating static helper classes
• TotT: Using Dependency Injection to Avoid Singletons

Yes, it's a smell: Hard-to-Test Code

I'd start with the following:

1. Create an interface for MyApiClient,
2. Remove the static modifier of signin,
3. Create a constructor in Sign which get a MyApiClient instance and store it in a field,
4. Modify the signin method to use the instance above.

public class Sign {

    private final MyApiClient client;

    public Sign(final MyApiClient client) {
        this.client = client;
    }

    public void signin(final String username, final String password, 
            final SigninResponseHandler responseHandler) {
        ...
        client.post(path, params, ...

Here you can create a Sign object with a mocked MyApiClient which is easier to test.

Some other notes:

1. Sign does not seem a good class name. From Clean Code, page 25:

   Classes and objects should have noun or noun phrase names like Customer, WikiPage, Account, and AddressParser. [...] A class name should not be a verb.

2. MyApiClient also should be renamed something meaningful.

Two useful readings:

• Eliminating static helper classes
• TotT: Using Dependency Injection to Avoid Singletons