pg_waldump: Fix --bkp-details to not issue spurious newlines for FPWs.
authorAndres Freund <andres@anarazel.de>
Wed, 30 Oct 2019 05:46:40 +0000 (22:46 -0700)
committerAndres Freund <andres@anarazel.de>
Wed, 30 Oct 2019 05:53:37 +0000 (22:53 -0700)
commit82200115e05501c633595c2a7b61143f0e610a00
treed4f0168724c66084833f9c0e7aec52dee2c80e23
parente3ff8c360e4d1f48eff0154aed654cc9d8f9529b
pg_waldump: Fix --bkp-details to not issue spurious newlines for FPWs.

The additional newline seems to have accidentally been introduced in
2c03216d831, in 9.5. The newline is only issued when an FPW is
present for the block reference.

While there could be an argument that removing the newlines in the
back branches could cause a problem for somebody parsing the
pg_waldump output, the likelihood of that seems small enough. It seems
at least equally likely that the randomness of when newlines are
issued causes problems.

Author: Andres Freund
Discussion: https://postgr.es/m/20191029233341.4gnyau7e5v2lh5sc@alap3.anarazel.de
Backpatch: 9.5, like 2c03216d831.
src/bin/pg_waldump/pg_waldump.c