Fix lookup error in extended stats ownership check
authorTomas Vondra <tomas.vondra@postgresql.org>
Tue, 31 Aug 2021 16:03:05 +0000 (18:03 +0200)
committerTomas Vondra <tomas.vondra@postgresql.org>
Tue, 31 Aug 2021 16:36:06 +0000 (18:36 +0200)
commita371a5ba349d9c39e7754f7d0f195ac46ee87b3f
treec68cccbb6e093f06f774ccf222c32a144a524532
parent983d7033df6e03134572eb75dd76603fb9245211
Fix lookup error in extended stats ownership check

When an ownership check on extended statistics object failed, the code
was calling aclcheck_error_type to report the failure, which is clearly
wrong, resulting in cache lookup errors. Fix by calling aclcheck_error.

This issue exists since the introduction of extended statistics, so
backpatch all the way back to PostgreSQL 10. It went unnoticed because
there were no tests triggering the error, so add one.

Reported-by: Mark Dilger
Backpatch-through: 10, where extended stats were introduced
Discussion: https://postgr.es/m/1F238937-7CC2-4703-A1B1-6DC225B8978A%40enterprisedb.com
src/backend/catalog/objectaddress.c
src/test/regress/expected/stats_ext.out
src/test/regress/sql/stats_ext.sql