Allow building without default socket directory
authorPeter Eisentraut <peter@eisentraut.org>
Fri, 31 Jan 2020 15:26:12 +0000 (16:26 +0100)
committerPeter Eisentraut <peter@eisentraut.org>
Fri, 31 Jan 2020 15:28:43 +0000 (16:28 +0100)
commita9cff89f7e638c060621a62ca35da97a12adde42
tree733f5f5cbc7af6abf965ae40c1139fffda0bf6ab
parent7c23bfd25c423b4513a16d41c5e4d09c32807155
Allow building without default socket directory

We have code paths for Unix socket support and no Unix socket support.
Now add a third variant: Unix socket support but do not use a Unix
socket by default in the client or the server, only if you explicitly
specify one.  This will be useful when we enable Unix socket support
on Windows.

To implement this, tweak things so that setting DEFAULT_PGSOCKET_DIR
to "" has the desired effect.  This mostly already worked like that;
only a few places needed to be adjusted.  Notably, the reference to
DEFAULT_PGSOCKET_DIR in UNIXSOCK_PATH() could be removed because all
callers already resolve an empty socket directory setting with a
default if appropriate.

Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>
Discussion: https://www.postgresql.org/message-id/75f72249-8ae6-322a-63df-4fe03eeccb9f@2ndquadrant.com
src/include/libpq/pqcomm.h
src/include/pg_config_manual.h
src/interfaces/libpq/fe-connect.c