pg_upgrade: make get_major_server_version() err msg consistent
authorBruce Momjian <bruce@momjian.us>
Thu, 19 Mar 2020 19:20:55 +0000 (15:20 -0400)
committerBruce Momjian <bruce@momjian.us>
Thu, 19 Mar 2020 19:20:55 +0000 (15:20 -0400)
commitc9c042dded8792913a0387bd7e9a0d8f7be00978
tree8b11efe7a4342d98d950cee75a83798b03f3191e
parentf4efb46d2230ef19165fec78b5c41a78cf6e1213
pg_upgrade:  make get_major_server_version() err msg consistent

This patch fixes the error message in get_major_server_version() to be
"could not parse version file", and uses the full file path name, rather
than just the data directory path.

Also, commit 4109bb5de4 added the cause of the failure to the  "could
not open" error message, and improved quoting.  This patch backpatches
the "could not open" cause to PG 12, where it was first widely used, and
backpatches the quoting fix in that patch to all supported releases.

Reported-by: Tom Lane
Discussion: https://postgr.es/m/87pne2w98h.fsf@wibble.ilmari.org

Author: Dagfinn Ilmari MannsÃ¥ker

Backpatch-through: 9.5
src/bin/pg_upgrade/server.c