Change mechanism to set up source targetlist in MERGE
authorAlvaro Herrera <alvherre@alvh.no-ip.org>
Tue, 12 Apr 2022 07:29:39 +0000 (09:29 +0200)
committerAlvaro Herrera <alvherre@alvh.no-ip.org>
Tue, 12 Apr 2022 07:29:39 +0000 (09:29 +0200)
commitce4f46fdc814eb1b704d81640f6d8f03625d0f53
tree782a82bc2a2a811751ea053ee9793d252d296011
parenta4b57543acfb52cc7c7e031501002563f536b929
Change mechanism to set up source targetlist in MERGE

We were setting MERGE source subplan's targetlist by expanding the
individual attributes of the source relation completely, early in the
parse analysis phase.  This failed to work when the condition of an
action included a whole-row reference, causing setrefs.c to error out
with
  ERROR:  variable not found in subplan target lists
because at that point there is nothing to resolve the whole-row
reference with.  We can fix this by having preprocess_targetlist expand
the source targetlist for Vars required from the source rel by all
actions.  Moreover, by using this expansion mechanism we can do away
with the targetlist expansion in transformMergeStmt, which is good
because then we no longer pull in columns that aren't needed for
anything.

Add a test case for the problem.

While at it, remove some redundant code in preprocess_targetlist():
MERGE was doing separately what is already being done for UPDATE/DELETE,
so we can just rely on the latter and remove the former.  (The handling
of inherited rels was different for MERGE, but that was a no-longer-
necessary hack.)

Fix outdated, related comments for fix_join_expr also.

Author: Richard Guo <guofenglinux@gmail.com>
Author: Álvaro Herrera <alvherre@alvh.no-ip.org>
Reported-by: Joe Wildish <joe@lateraljoin.com>
Discussion: https://postgr.es/m/fab3b90a-914d-46a9-beb0-df011ee39ee5@www.fastmail.com
src/backend/optimizer/plan/setrefs.c
src/backend/optimizer/prep/preptlist.c
src/backend/parser/parse_merge.c
src/test/regress/expected/merge.out
src/test/regress/expected/with.out
src/test/regress/sql/merge.sql