Stop demanding that top xact must be seen before subxact in decoding.
authorAmit Kapila <akapila@postgresql.org>
Wed, 12 Feb 2020 05:53:24 +0000 (11:23 +0530)
committerAmit Kapila <akapila@postgresql.org>
Wed, 19 Feb 2020 02:45:49 +0000 (08:15 +0530)
commite3ff789acfb2754cd7b5e87f6f4463fd08e35996
tree86558cf5661b8f0723c85cec5845dcc41c15fdc2
parentfe9b92854e7d5f66d3abb565c5b60a879b6c9442
Stop demanding that top xact must be seen before subxact in decoding.

Manifested as

ERROR:  subtransaction logged without previous top-level txn record

this check forbids legit behaviours like
 - First xl_xact_assignment record is beyond reading, i.e. earlier
   restart_lsn.
 - After restart_lsn there is some change of a subxact.
 - After that, there is second xl_xact_assignment (for another subxact)
   revealing the relationship between top and first subxact.

Such a transaction won't be streamed anyway because we hadn't seen it in
full.  Saying for sure whether xact of some record encountered after
the snapshot was deserialized can be streamed or not requires to know
whether it wrote something before deserialization point --if yes, it
hasn't been seen in full and can't be decoded. Snapshot doesn't have such
info, so there is no easy way to relax the check.

Reported-by: Hsu, John
Diagnosed-by: Arseny Sher
Author: Arseny Sher, Amit Kapila
Reviewed-by: Amit Kapila, Dilip Kumar
Backpatch-through: 9.5
Discussion: https://postgr.es/m/AB5978B2-1772-4FEE-A245-74C91704ECB0@amazon.com
contrib/test_decoding/Makefile
contrib/test_decoding/expected/subxact_without_top.out [new file with mode: 0644]
contrib/test_decoding/specs/subxact_without_top.spec [new file with mode: 0644]
src/backend/replication/logical/reorderbuffer.c