Ensure the previous Perl interpreter selection is restored upon exit from

plperl_call_handler, in both the normal and error-exit paths.  Per report
from Alexey Klyukin.

diff --git a/src/pl/plperl/plperl.c b/src/pl/plperl/plperl.c
index 3437c92b2534486b04c1dec6b54f7371ce9079ec..6caf66e0b5525641370dd0eb0e0ad8bda73eec9f 100644 (file)
--- a/src/pl/plperl/plperl.c
+++ b/src/pl/plperl/plperl.c
@@ -1,7 +1,7 @@
 /**********************************************************************
  * plperl.c - perl as a procedural language for PostgreSQL
  *
- *   $PostgreSQL: pgsql/src/pl/plperl/plperl.c,v 1.136.2.3 2009/09/28 17:30:41 adunstan Exp $
+ *   $PostgreSQL: pgsql/src/pl/plperl/plperl.c,v 1.136.2.4 2009/10/31 18:12:12 tgl Exp $
  *
  **********************************************************************/
 
@@ -140,8 +140,8 @@ void        _PG_init(void);
 static void plperl_init_interp(void);
 
 static Datum plperl_func_handler(PG_FUNCTION_ARGS);
-
 static Datum plperl_trigger_handler(PG_FUNCTION_ARGS);
+
 static plperl_proc_desc *compile_plperl_function(Oid fn_oid, bool is_trigger);
 
 static SV  *plperl_hash_from_tuple(HeapTuple tuple, TupleDesc tupdesc);
@@ -365,11 +365,13 @@ check_interp(bool trusted)
    }
 }
 
-
+/*
+ * Restore previous interpreter selection, if two are active
+ */
 static void
 restore_context(bool old_context)
 {
-   if (trusted_context != old_context)
+   if (interp_state == INTERP_BOTH && trusted_context != old_context)
    {
        if (old_context)
            PERL_SET_CONTEXT(plperl_trusted_interp);
@@ -853,9 +855,9 @@ Datum
 plperl_call_handler(PG_FUNCTION_ARGS)
 {
    Datum       retval;
-   plperl_call_data *save_call_data;
+   plperl_call_data *save_call_data = current_call_data;
+   bool        oldcontext = trusted_context;
 
-   save_call_data = current_call_data;
    PG_TRY();
    {
        if (CALLED_AS_TRIGGER(fcinfo))
@@ -866,11 +868,13 @@ plperl_call_handler(PG_FUNCTION_ARGS)
    PG_CATCH();
    {
        current_call_data = save_call_data;
+       restore_context(oldcontext);
        PG_RE_THROW();
    }
    PG_END_TRY();
 
    current_call_data = save_call_data;
+   restore_context(oldcontext);
    return retval;
 }
 
@@ -1215,7 +1219,6 @@ plperl_func_handler(PG_FUNCTION_ARGS)
    Datum       retval;
    ReturnSetInfo *rsi;
    SV         *array_ret = NULL;
-   bool        oldcontext = trusted_context;
 
    /*
     * Create the call_data beforing connecting to SPI, so that it is not
@@ -1355,9 +1358,6 @@ plperl_func_handler(PG_FUNCTION_ARGS)
    if (array_ret == NULL)
        SvREFCNT_dec(perlret);
 
-   current_call_data = NULL;
-   restore_context(oldcontext);
-
    return retval;
 }
 
@@ -1370,7 +1370,6 @@ plperl_trigger_handler(PG_FUNCTION_ARGS)
    Datum       retval;
    SV         *svTD;
    HV         *hvTD;
-   bool        oldcontext = trusted_context;
 
    /*
     * Create the call_data beforing connecting to SPI, so that it is not
@@ -1458,8 +1457,6 @@ plperl_trigger_handler(PG_FUNCTION_ARGS)
    if (perlret)
        SvREFCNT_dec(perlret);
 
-   current_call_data = NULL;
-   restore_context(oldcontext);
    return retval;
 }