From: Magnus Hagander <magnus@hagander.net>
Date: Sun, 16 Sep 2018 21:47:52 +0000 (+0200)
Subject: Don't fail on incorrect statuses in URL
X-Git-Url: http://git.postgresql.org/gitweb/static/gitweb.js?a=commitdiff_plain;h=84151808c02beacac4395c506189ee743bc9f260;p=pgcommitfest2.git

Don't fail on incorrect statuses in URL

The comment said we should ignore the status if int() on it fails, but
to do that we have to fail it before we actually add the WHERE clause.
Thus, reorder the code to do so.
---

diff --git a/pgcommitfest/commitfest/views.py b/pgcommitfest/commitfest/views.py
index 3ee60e3..cc94950 100644
--- a/pgcommitfest/commitfest/views.py
+++ b/pgcommitfest/commitfest/views.py
@@ -108,8 +108,8 @@ def commitfest(request, cfid):
 	whereparams = {}
 	if request.GET.has_key('status') and request.GET['status'] != "-1":
 		try:
-			whereclauses.append("poc.status=%(status)s")
 			whereparams['status'] = int(request.GET['status'])
+			whereclauses.append("poc.status=%(status)s")
 		except ValueError:
 			# int() failed -- so just ignore this filter
 			pass