From: Neil Conway <neilc@samurai.com>
Date: Sat, 12 Jan 2008 10:38:32 +0000 (+0000)
Subject: Minor perf tweak for _SPI_strdup(): if we're going to call strlen()
X-Git-Url: http://git.postgresql.org/gitweb/static/gitweb.js?a=commitdiff_plain;h=a7342052a077f1389af2c7231943768b951d9cfa;p=users%2Fbernd%2Fpostgres.git

Minor perf tweak for _SPI_strdup(): if we're going to call strlen()
anyway, it is faster to memcpy() than to strcpy().
---

diff --git a/src/backend/utils/adt/xml.c b/src/backend/utils/adt/xml.c
index bdb31b4562..7ae82b588d 100644
--- a/src/backend/utils/adt/xml.c
+++ b/src/backend/utils/adt/xml.c
@@ -1821,9 +1821,10 @@ map_sql_value_to_xml_value(Datum value, Oid type)
 static char *
 _SPI_strdup(const char *s)
 {
-	char	   *ret = SPI_palloc(strlen(s) + 1);
+	size_t		len = strlen(s) + 1;
+	char	   *ret = SPI_palloc(len);
 
-	strcpy(ret, s);
+	memcpy(ret, s, len);
 	return ret;
 }