From d45fd537e43d58af340d2da2cdc921d2e85bac50 Mon Sep 17 00:00:00 2001 From: Tomas Vondra Date: Fri, 14 Jul 2017 21:57:48 +0200 Subject: [PATCH] Accept int2vector not being hash distributable Upstream commit 5c80642aa8de8393b08cd3cbf612b325cedd98dc removed support for hashing int2vector data type, as it was dead code (upstream). That means we can no longer distribute table by hash on this datatype. We could reintroduce the hash function in Postgres-XL, but int2vector seems rarely used as distribution key, so let's just fix the tests. If needed, we can add the functions in the future. --- .../regress/expected/xl_distribution_column_types.out | 9 --------- src/test/regress/sql/xl_distribution_column_types.sql | 10 ---------- 2 files changed, 19 deletions(-) diff --git a/src/test/regress/expected/xl_distribution_column_types.out b/src/test/regress/expected/xl_distribution_column_types.out index e372c4a27b..8d9ac799d8 100644 --- a/src/test/regress/expected/xl_distribution_column_types.out +++ b/src/test/regress/expected/xl_distribution_column_types.out @@ -34,14 +34,6 @@ CREATE TABLE xl_dc4 ( name text, price numeric ) DISTRIBUTE BY HASH (is_available); ---INT2VECTOR, -CREATE TABLE xl_dc5 ( - product_no integer, - product_id integer, - sub_product_ids INT2VECTOR PRIMARY KEY, - name text, - price numeric -) DISTRIBUTE BY HASH (sub_product_ids); --OIDVECTOR, CREATE TABLE xl_dc6 ( product_no integer, @@ -199,7 +191,6 @@ DROP TABLE xl_dc1; DROP TABLE xl_dc2; DROP TABLE xl_dc3; DROP TABLE xl_dc4; -DROP TABLE xl_dc5; DROP TABLE xl_dc6; DROP TABLE xl_dc7; DROP TABLE xl_dc8; diff --git a/src/test/regress/sql/xl_distribution_column_types.sql b/src/test/regress/sql/xl_distribution_column_types.sql index 486b730cf1..d8580d98a7 100644 --- a/src/test/regress/sql/xl_distribution_column_types.sql +++ b/src/test/regress/sql/xl_distribution_column_types.sql @@ -44,15 +44,6 @@ CREATE TABLE xl_dc4 ( price numeric ) DISTRIBUTE BY HASH (is_available); ---INT2VECTOR, -CREATE TABLE xl_dc5 ( - product_no integer, - product_id integer, - sub_product_ids INT2VECTOR PRIMARY KEY, - name text, - price numeric -) DISTRIBUTE BY HASH (sub_product_ids); - --OIDVECTOR, CREATE TABLE xl_dc6 ( product_no integer, @@ -231,7 +222,6 @@ DROP TABLE xl_dc1; DROP TABLE xl_dc2; DROP TABLE xl_dc3; DROP TABLE xl_dc4; -DROP TABLE xl_dc5; DROP TABLE xl_dc6; DROP TABLE xl_dc7; DROP TABLE xl_dc8; -- 2.39.5