From d508f43a10fc0ca9fa422d1408f9e6178916f8e1 Mon Sep 17 00:00:00 2001 From: Tom Lane Date: Sat, 23 Apr 2005 18:49:54 +0000 Subject: [PATCH] Add comment about checkpoint panic behavior during shutdown, per suggestion from Qingqing Zhou. --- src/backend/access/transam/xlog.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/backend/access/transam/xlog.c b/src/backend/access/transam/xlog.c index 51579c4f92..6fddcb54b8 100644 --- a/src/backend/access/transam/xlog.c +++ b/src/backend/access/transam/xlog.c @@ -4925,7 +4925,10 @@ CreateCheckPoint(bool shutdown, bool force) * * This I/O could fail for various reasons. If so, we will fail to * complete the checkpoint, but there is no reason to force a system - * panic. Accordingly, exit critical section while doing it. + * panic. Accordingly, exit critical section while doing it. (If + * we are doing a shutdown checkpoint, we probably *should* panic --- + * but that will happen anyway because we'll still be inside the + * critical section established by ShutdownXLOG.) */ END_CRIT_SECTION(); -- 2.39.5