Upgrade to Angular 0.9.10 & misc changes #102
Conversation
Chapter_05/lib/recipe_book.dart
Outdated
There was a problem hiding this comment.
Nice change. But why call to parameter d? Maybe m for map or r for recipe-in-json-format :).
There was a problem hiding this comment.
d for data but if you prefer something else it could be changed
|
Hi, @vicb, what's the status of this request? I can't automatically merge it, but aside from that, would it be ready? (Do you need to wait for the fix to dart-archive/angular.dart#715 to become available on pub.dartlang.org?) |
|
The 0.9.9 is buggy (the issue you mentionned) so I have put this on hold - I'll rebase next week on 0.10 and remove the WIP prefix to indicate when it's ready ! |
|
OK, makes sense. Thanks! |
|
@vicb are you still planning to rebase on 0.10? |
|
Kathy, I was off last week. I will handle this soon. On 31 mars 2014 20:10:15 CEST, Kathy Walrath notifications@github.com wrote:
|
|
@kwalrath almost done, pending dart-archive/angular.dart#824 (is this is an ng issue, I'll push the updates tomorrow). |
|
@kwalrath I think you can merge this one. Due to the bug I mention in the previous comment, the clear button does not clear the filters (checkboxes) other than that everything works. Ping me once/if you merge this so that i can update angulardart.org |
|
OK, merging now. Please update angulardart.org accordingly. Thanks, @vicb! |
|
Actually... Do you want to coordinate this merge with the angulardart.org merge? The less they diverge, the better. And I'd do both the merges, anyway. |
There was a problem hiding this comment.
I think all .lock files should be using 0.10.1+2
There was a problem hiding this comment.
Kathy, please merge as soon as you can, I'll make sure to update the text quickly - I don't want to wait & have to debase.
Patrice, we don't care. Plus it's unit test so we really don't care.
On 3 avril 2014 03:33:38 CEST, Patrice Chalin notifications@github.com wrote:
@@ -88,7 +88,7 @@ packages:
unittest:
description: unittest
source: hosted
- version: "0.10.1"
- version: "0.10.1+1"
I think all .lock files should be using 0.10.1+2
Reply to this email directly or view it on GitHub:
https://github.com/angular/angular.dart.tutorial/pull/102/files#r11236406
[WIP] Upgrade to Angular 0.9.10 & misc changes
|
OK, merged. Looking forward to the text update, @vicb. |
Is that peer pressure ;) Thanks for the merge, I'll update ASAP |
|
Yes, @vicb, I'm big on peer pressure. :) |
There was a problem hiding this comment.
Sorry can't remember, feel free to update.
There was a problem hiding this comment.
Awe, Vic, I thought you'd support me on this one! ;) I'll revert back to Kathy's preferred style (along with a bug fix).
This dart-archive/angular.dart#715 needs to be fixed first