Add ICACHE_RAM_ATTR compatibility macro with esp8266 #760
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This help the ESP8266 libraries to run on ESP32
Contributor
Author
Member
|
let's add a file called "esp8266-compat.h" and put that and ICACHE_FLASH_ATTR and maybe more in near future :) include that header into Arduino.h |
Contributor
Author
|
Nice idea! The strangest thing is that there are some ICACHE_FLASH_ATTR calls in the actual ESP32 core: |
Member
|
it evaluates to nothing and prolly not called anywhere to get the undefined error :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This help the ESP8266 libraries to run on ESP32