Commit 3bf05e0
committed
Add a new upper planner relation for partially-aggregated results.
Up until now, we've abused grouped_rel->partial_pathlist as a place to
store partial paths that have been partially aggregate, but that's
really not correct, because a partial path for a relation is supposed
to be one which produces the correct results with the addition of only
a Gather or Gather Merge node, and these paths also require a Finalize
Aggregate step. Instead, add a new partially_group_rel which can hold
either partial paths (which need to be gathered and then have
aggregation finalized) or non-partial paths (which only need to have
aggregation finalized). This allows us to reuse generate_gather_paths
for partially_grouped_rel instead of writing new code, so that this
patch actually basically no net new code while making things cleaner,
simplifying things for pending patches for partition-wise aggregate.
Robert Haas and Jeevan Chalke. The larger patch series of which this
patch is a part was also reviewed and tested by Antonin Houska,
Rajkumar Raghuwanshi, David Rowley, Dilip Kumar, Konstantin Knizhnik,
Pascal Legrand, Rafia Sabih, and me.
Discussion: http://postgr.es/m/CA+TgmobrzFYS3+U8a_BCy3-hOvh5UyJbC18rEcYehxhpw5=ETA@mail.gmail.com
Discussion: http://postgr.es/m/CA+TgmoZyQEjdBNuoG9-wC5GQ5GrO4544Myo13dVptvx+uLg9uQ@mail.gmail.com1 parent 5b570d7 commit 3bf05e0
File tree
6 files changed
+154
-153
lines changed- src
- backend/optimizer
- geqo
- path
- plan
- include
- nodes
- optimizer
6 files changed
+154
-153
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
998 | 998 | | |
999 | 999 | | |
1000 | 1000 | | |
| 1001 | + | |
1001 | 1002 | | |
1002 | 1003 | | |
1003 | 1004 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
268 | 268 | | |
269 | 269 | | |
270 | 270 | | |
271 | | - | |
| 271 | + | |
272 | 272 | | |
273 | 273 | | |
274 | 274 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
488 | 488 | | |
489 | 489 | | |
490 | 490 | | |
491 | | - | |
| 491 | + | |
492 | 492 | | |
493 | 493 | | |
494 | 494 | | |
| |||
2444 | 2444 | | |
2445 | 2445 | | |
2446 | 2446 | | |
| 2447 | + | |
| 2448 | + | |
| 2449 | + | |
| 2450 | + | |
| 2451 | + | |
| 2452 | + | |
| 2453 | + | |
2447 | 2454 | | |
2448 | 2455 | | |
2449 | | - | |
| 2456 | + | |
2450 | 2457 | | |
2451 | 2458 | | |
2452 | 2459 | | |
2453 | 2460 | | |
| 2461 | + | |
| 2462 | + | |
2454 | 2463 | | |
2455 | 2464 | | |
2456 | 2465 | | |
2457 | 2466 | | |
2458 | 2467 | | |
| 2468 | + | |
| 2469 | + | |
| 2470 | + | |
| 2471 | + | |
2459 | 2472 | | |
2460 | 2473 | | |
2461 | 2474 | | |
2462 | 2475 | | |
2463 | 2476 | | |
2464 | 2477 | | |
| 2478 | + | |
| 2479 | + | |
2465 | 2480 | | |
2466 | 2481 | | |
2467 | | - | |
| 2482 | + | |
2468 | 2483 | | |
2469 | 2484 | | |
2470 | 2485 | | |
| |||
2479 | 2494 | | |
2480 | 2495 | | |
2481 | 2496 | | |
| 2497 | + | |
2482 | 2498 | | |
2483 | | - | |
| 2499 | + | |
2484 | 2500 | | |
2485 | 2501 | | |
2486 | 2502 | | |
| |||
2653 | 2669 | | |
2654 | 2670 | | |
2655 | 2671 | | |
2656 | | - | |
| 2672 | + | |
2657 | 2673 | | |
2658 | 2674 | | |
2659 | 2675 | | |
| |||
0 commit comments