From f6315cd5feddb2e9ea168bcad391b29990b53afb Mon Sep 17 00:00:00 2001 From: Tuomo Raitila Date: Mon, 2 Oct 2023 05:59:12 +0300 Subject: [PATCH 1/2] Fix for calling non-cancellable scroll events (#5672) Co-authored-by: Luke Bennett --- .changeset/brown-lemons-film.md | 5 +++++ packages/react-select/src/internal/useScrollCapture.ts | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) create mode 100644 .changeset/brown-lemons-film.md diff --git a/.changeset/brown-lemons-film.md b/.changeset/brown-lemons-film.md new file mode 100644 index 0000000000..59fc1fb74a --- /dev/null +++ b/.changeset/brown-lemons-film.md @@ -0,0 +1,5 @@ +--- +'react-select': patch +--- + +Fix for calling non-cancellable scroll events diff --git a/packages/react-select/src/internal/useScrollCapture.ts b/packages/react-select/src/internal/useScrollCapture.ts index 6452d6564e..03b8bd9f59 100644 --- a/packages/react-select/src/internal/useScrollCapture.ts +++ b/packages/react-select/src/internal/useScrollCapture.ts @@ -2,7 +2,7 @@ import { useCallback, useEffect, useRef } from 'react'; import { supportsPassiveEvents } from '../utils'; const cancelScroll = (event: WheelEvent | TouchEvent) => { - event.preventDefault(); + if (event.cancelable) event.preventDefault(); event.stopPropagation(); }; From d598ac67c40ee95cd0264ba8a65adc053975e8ff Mon Sep 17 00:00:00 2001 From: "github-actions[bot]" <41898282+github-actions[bot]@users.noreply.github.com> Date: Mon, 2 Oct 2023 14:09:37 +1100 Subject: [PATCH 2/2] Version Packages (#5763) Co-authored-by: github-actions[bot] --- .changeset/brown-lemons-film.md | 5 ----- packages/react-select/CHANGELOG.md | 6 ++++++ packages/react-select/package.json | 2 +- 3 files changed, 7 insertions(+), 6 deletions(-) delete mode 100644 .changeset/brown-lemons-film.md diff --git a/.changeset/brown-lemons-film.md b/.changeset/brown-lemons-film.md deleted file mode 100644 index 59fc1fb74a..0000000000 --- a/.changeset/brown-lemons-film.md +++ /dev/null @@ -1,5 +0,0 @@ ---- -'react-select': patch ---- - -Fix for calling non-cancellable scroll events diff --git a/packages/react-select/CHANGELOG.md b/packages/react-select/CHANGELOG.md index c01d4c80da..c1df62f11c 100644 --- a/packages/react-select/CHANGELOG.md +++ b/packages/react-select/CHANGELOG.md @@ -1,5 +1,11 @@ # react-select +## 5.7.6 + +### Patch Changes + +- [`f6315cd5`](https://github.com/JedWatson/react-select/commit/f6315cd5feddb2e9ea168bcad391b29990b53afb) [#5672](https://github.com/JedWatson/react-select/pull/5672) Thanks [@tu4mo](https://github.com/tu4mo)! - Fix for calling non-cancellable scroll events + ## 5.7.5 ### Patch Changes diff --git a/packages/react-select/package.json b/packages/react-select/package.json index f87891755f..6a52557e6f 100644 --- a/packages/react-select/package.json +++ b/packages/react-select/package.json @@ -1,6 +1,6 @@ { "name": "react-select", - "version": "5.7.5", + "version": "5.7.6", "description": "A Select control built with and for ReactJS", "main": "dist/react-select.cjs.js", "module": "dist/react-select.esm.js",