fix: restore closing SMTP message on method exit #14496
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of #14495
If we don't call
message.Close()once the method exits, we could leak resources.This restores the
defer, but conditionalizes it such that it will only callClose()if it hasn't already been called. If we don't do this, the SMTP lib will send a subsequent line to the server after an error response, which is invalid. It's not a trainsmash, but it's better to be defensive.