Commit 6f4f7f5
committed
Update Ruff configuration
This resolves two warnings about Ruff configuration, by:
- No longer setting `ignore-init-module-imports = true` explicitly,
which was deprecated since `ruff` 0.4.4. We primarily use `ruff`
via `pre-commit`, for which this deprecation has applied since we
upgraded the version in `.pre-commit-config.yaml` from 0.4.3 to
0.6.0 in d1582d1 (#1953).
We continue to list `F401` ("Module imported but unused") as not
automatically fixable, to avoid inadvertently removing imports
that may be needed.
See also:
https://docs.astral.sh/ruff/settings/#lint_ignore-init-module-imports
- Rename the rule `TCH004` to `TC004`, since `TCH004` is the old
name that may eventually be removed and that is deprecated since
0.8.0. We upgraded `ruff` in `.pre-commit-config.yml` again in
b7ce712 (#2031), from 0.6.0 to 0.11.12, at which point this
deprecation applied.
See also https://astral.sh/blog/ruff-v0.8.0.
These changes make those configuration-related warnings go away,
and no new diagnostics (errors/warnings) are produced when running
`ruff check` or `pre-commit run --all-files`. No F401-related
diagnostics are triggered when testing with explicit
`ignore-init-module-imports = false`, in preview mode or otherwise.
In addition, this commit makes two changes that are not needed to
resolve warnings:
- Stop excluding `E203` ("Whitespace before ':'"). That diagnostic
is no longer failing with the current code here in the current
version of `ruff`, and code changes that would cause it to fail
would likely be accidentally mis-st
- Add the version lower bound `>=0.8` for `ruff` in
`requirements-dev.txt`. That file is rarely used, as noted in
a8a73ff (#1871), but as long as we have it, there may be a
benefit to excluding dependency versions for which our
configuration is no longer compatible. This is the only change in
this commit outside of `pyproject.toml`.1 parent 1b79d44 commit 6f4f7f5
2 files changed
+5
-7
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
60 | 60 | | |
61 | 61 | | |
62 | 62 | | |
63 | | - | |
64 | | - | |
65 | | - | |
66 | | - | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
67 | 67 | | |
68 | 68 | | |
69 | | - | |
70 | 69 | | |
71 | 70 | | |
72 | | - | |
73 | 71 | | |
74 | 72 | | |
75 | 73 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
5 | | - | |
| 5 | + | |
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
0 commit comments