Replace assert_true with assertTrue

Also change TestOutputStream to subclass TestBase rather than object

Author: Harmon758

git/test/lib/asserts.py

@@ -7,8 +7,7 @@
 from unittest.mock import patch
 
 from nose.tools import (
-    assert_true,        # @UnusedImport
     assert_false        # @UnusedImport
 )
 
-__all__ = ['patch', 'assert_true', 'assert_false']
+__all__ = ['patch', 'assert_false']

git/test/test_diff.py

@@ -20,7 +20,6 @@
     TestBase,
     StringProcessAdapter,
     fixture,
-    assert_true,
 )
 from git.test.lib import with_rw_directory
 
@@ -105,8 +104,8 @@ def test_diff_with_rename(self):
         self.assertEqual(1, len(diffs))
 
         diff = diffs[0]
-        assert_true(diff.renamed_file)
-        assert_true(diff.renamed)
+        self.assertTrue(diff.renamed_file)
+        self.assertTrue(diff.renamed)
         self.assertEqual(diff.rename_from, u'Jérôme')
         self.assertEqual(diff.rename_to, u'müller')
         self.assertEqual(diff.raw_rename_from, b'J\xc3\xa9r\xc3\xb4me')
@@ -133,9 +132,9 @@ def test_diff_with_copied_file(self):
         self.assertEqual(1, len(diffs))
 
         diff = diffs[0]
-        assert_true(diff.copied_file)
-        assert_true(diff.a_path, u'test1.txt')
-        assert_true(diff.b_path, u'test2.txt')
+        self.assertTrue(diff.copied_file)
+        self.assertTrue(diff.a_path, u'test1.txt')
+        self.assertTrue(diff.b_path, u'test2.txt')
         assert isinstance(str(diff), str)
 
         output = StringProcessAdapter(fixture('diff_copied_mode_raw'))

git/test/test_fun.py

@@ -19,7 +19,6 @@
     find_worktree_git_dir
 )
 from git.test.lib import (
-    assert_true,
     TestBase,
     with_rw_repo,
     with_rw_directory
@@ -274,12 +273,12 @@ def test_linked_worktree_traversal(self, rw_dir):
 
         dotgit = osp.join(worktree_path, ".git")
         statbuf = stat(dotgit)
-        assert_true(statbuf.st_mode & S_IFREG)
+        self.assertTrue(statbuf.st_mode & S_IFREG)
 
         gitdir = find_worktree_git_dir(dotgit)
         self.assertIsNotNone(gitdir)
         statbuf = stat(gitdir)
-        assert_true(statbuf.st_mode & S_IFDIR)
+        self.assertTrue(statbuf.st_mode & S_IFDIR)
 
     def test_tree_entries_from_data_with_failing_name_decode_py3(self):
         r = tree_entries_from_data(b'100644 \x9f\0aaa')

git/test/test_git.py

@@ -22,7 +22,6 @@
 from git.test.lib import (
     TestBase,
     patch,
-    assert_true,
     fixture_path
 )
 from git.test.lib import with_rw_directory
@@ -48,7 +47,7 @@ def tearDown(self):
     def test_call_process_calls_execute(self, git):
         git.return_value = ''
         self.git.version()
-        assert_true(git.called)
+        self.assertTrue(git.called)
         self.assertEqual(git.call_args, ((['git', 'version'],), {}))
 
     def test_call_unpack_args_unicode(self):
@@ -95,7 +94,7 @@ def test_it_accepts_stdin(self):
     def test_it_ignores_false_kwargs(self, git):
         # this_should_not_be_ignored=False implies it *should* be ignored
         self.git.version(pass_this_kwarg=False)
-        assert_true("pass_this_kwarg" not in git.call_args[1])
+        self.assertTrue("pass_this_kwarg" not in git.call_args[1])
 
     def test_it_raises_proper_exception_with_output_stream(self):
         tmp_file = TemporaryFile()

git/test/test_repo.py

@@ -41,8 +41,7 @@
     TestBase,
     with_rw_repo,
     fixture,
-    assert_false,
-    assert_true
+    assert_false
 )
 from git.util import HIDE_WINDOWS_KNOWN_ERRORS, cygpath
 from git.test.lib import with_rw_directory
@@ -243,12 +242,12 @@ def test_clone_from_with_path_contains_unicode(self):
 
     @with_rw_repo('HEAD')
     def test_max_chunk_size(self, repo):
-        class TestOutputStream(object):
+        class TestOutputStream(TestBase):
             def __init__(self, max_chunk_size):
                 self.max_chunk_size = max_chunk_size
 
             def write(self, b):
-                assert_true(len(b) <= self.max_chunk_size)
+                self.assertTrue(len(b) <= self.max_chunk_size)
 
         for chunk_size in [16, 128, 1024]:
             repo.git.status(output_stream=TestOutputStream(chunk_size), max_chunk_size=chunk_size)
@@ -404,7 +403,7 @@ def test_should_display_blame_information(self, git):
         # self.assertEqual(25, reduce(lambda acc, x: acc + len(x[-1]), b))
         self.assertEqual(hash(b[0][0]), hash(b[9][0]))
         c = b[0][0]
-        assert_true(git.called)
+        self.assertTrue(git.called)
 
         self.assertEqual('634396b2f541a9f2d58b00be1a07f0c358b999b3', c.hexsha)
         self.assertEqual('Tom Preston-Werner', c.author.name)
@@ -417,9 +416,9 @@ def test_should_display_blame_information(self, git):
 
         # test the 'lines per commit' entries
         tlist = b[0][1]
-        assert_true(tlist)
-        assert_true(isinstance(tlist[0], str))
-        assert_true(len(tlist) < sum(len(t) for t in tlist))               # test for single-char bug
+        self.assertTrue(tlist)
+        self.assertTrue(isinstance(tlist[0], str))
+        self.assertTrue(len(tlist) < sum(len(t) for t in tlist))               # test for single-char bug
 
         # BINARY BLAME
         git.return_value = fixture('blame_binary')