Added conditional usage of the --progress flag to all relevant methods, that is push, fetch, pull and clone. This allows progress information to be sent in newer git versions without breaking older ones (ideally)

Author: Byron

git/remote.py

@@ -24,11 +24,7 @@
 					TagReference
 				)
 
-from git.util import  (
-						join_path,
-						_digest_process_messages,
-						_finalize_proc
-					)
+from git.util import join_path
 from gitdb.util import join
 
 import re
@@ -37,6 +33,58 @@
 
 __all__ = ('RemoteProgress', 'PushInfo', 'FetchInfo', 'Remote')
 
+#{ Utilities
+
+def digest_process_messages(fh, progress):
+	"""Read progress messages from file-like object fh, supplying the respective
+	progress messages to the progress instance.
+	
+	:param fh: File handle to read from 
+	:return: list(line, ...) list of lines without linebreaks that did
+		not contain progress information"""
+	line_so_far = ''
+	dropped_lines = list()
+	while True:
+		char = fh.read(1)
+		if not char:
+			break
+
+		if char in ('\r', '\n'):
+			dropped_lines.extend(progress._parse_progress_line(line_so_far))
+			line_so_far = ''
+		else:
+			line_so_far += char
+		# END process parsed line
+	# END while file is not done reading
+	return dropped_lines
+
+def finalize_process(proc):
+	"""Wait for the process (clone, fetch, pull or push) and handle its errors accordingly"""
+	try:
+		proc.wait()
+	except GitCommandError,e:
+		# if a push has rejected items, the command has non-zero return status
+		# a return status of 128 indicates a connection error - reraise the previous one
+		if proc.poll() == 128:
+			raise
+		pass
+	# END exception handling
+
+def add_progress(kwargs, git, progress):
+	"""Add the --progress flag to the given kwargs dict if supported by the 
+	git command. If the actual progress in the given progress instance is not 
+	given, we do not request any progress
+	:return: possibly altered kwargs"""
+	if progress is not None:
+		v = git.version_info
+		if v[0] > 1 or v[1] > 7 or v[2] > 0 or v[3] > 3:
+			kwargs['progress'] = True
+		#END handle --progress
+	#END handle progress
+	return kwargs
+
+#} END utilities
+
 
 class PushInfo(object):
 	"""
@@ -445,7 +493,7 @@ def _get_fetch_info_from_stderr(self, proc, progress):
 		# this also waits for the command to finish
 		# Skip some progress lines that don't provide relevant information
 		fetch_info_lines = list()
-		for line in _digest_process_messages(proc.stderr, progress):
+		for line in digest_process_messages(proc.stderr, progress):
 			if line.startswith('From') or line.startswith('remote: Total'):
 				continue
 			elif line.startswith('warning:'):
@@ -467,15 +515,15 @@ def _get_fetch_info_from_stderr(self, proc, progress):
 		output.extend(FetchInfo._from_line(self.repo, err_line, fetch_line) 
 						for err_line,fetch_line in zip(fetch_info_lines, fetch_head_info))
 
-		_finalize_proc(proc)
+		finalize_process(proc)
 		return output
 
 	def _get_push_info(self, proc, progress):
 		# read progress information from stderr
 		# we hope stdout can hold all the data, it should ...
 		# read the lines manually as it will use carriage returns between the messages
 		# to override the previous one. This is why we read the bytes manually
-		_digest_process_messages(proc.stderr, progress)
+		digest_process_messages(proc.stderr, progress)
 
 		output = IterableList('name')
 		for line in proc.stdout.readlines():
@@ -487,7 +535,7 @@ def _get_push_info(self, proc, progress):
 			# END exception handling 
 		# END for each line
 
-		_finalize_proc(proc)
+		finalize_process(proc)
 		return output
 
 
@@ -514,6 +562,7 @@ def fetch(self, refspec=None, progress=None, **kwargs):
 		:note:
 			As fetch does not provide progress information to non-ttys, we cannot make 
 			it available here unfortunately as in the 'push' method."""
+		kwargs = add_progress(kwargs, self.repo.git, progress)
 		proc = self.repo.git.fetch(self, refspec, with_extended_output=True, as_process=True, v=True, **kwargs)
 		return self._get_fetch_info_from_stderr(proc, progress or RemoteProgress())
 
@@ -525,6 +574,7 @@ def pull(self, refspec=None, progress=None, **kwargs):
 		:param progress: see 'push' method
 		:param kwargs: Additional arguments to be passed to git-pull
 		:return: Please see 'fetch' method """
+		kwargs = add_progress(kwargs, self.repo.git, progress)
 		proc = self.repo.git.pull(self, refspec, with_extended_output=True, as_process=True, v=True, **kwargs)
 		return self._get_fetch_info_from_stderr(proc, progress or RemoteProgress())
 
@@ -546,6 +596,7 @@ def push(self, refspec=None, progress=None, **kwargs):
 			in their flags.
 			If the operation fails completely, the length of the returned IterableList will
 			be null."""
+		kwargs = add_progress(kwargs, self.repo.git, progress)
 		proc = self.repo.git.push(self, refspec, porcelain=True, as_process=True, **kwargs)
 		return self._get_push_info(proc, progress or RemoteProgress())
 

git/repo/base.py

@@ -11,18 +11,18 @@
 from git.index import IndexFile
 from git.objects import *
 from git.config import GitConfigParser
-from git.remote import Remote
+from git.remote import (
+						Remote,
+						digest_process_messages,
+						finalize_process,
+						add_progress
+					)
+
 from git.db import (
 				GitCmdObjectDB, 
 				GitDB
 				)
 
-
-from git.util import (
-						_digest_process_messages,
-						_finalize_proc
-					)
-
 from gitdb.util import (
 							join,
 							isfile,
@@ -684,10 +684,11 @@ def _clone(cls, git, url, path, odb_default_type, progress, **kwargs):
 		# END windows handling 
 
 		try:
-			proc = git.clone(url, path, with_extended_output=True, as_process=True, v=True, progress=True, **kwargs)
+			proc = git.clone(url, path, with_extended_output=True, as_process=True, v=True, **add_progress(kwargs, git, progress))
 			if progress:
-				_digest_process_messages(proc.stderr, progress)
-			_finalize_proc(proc)
+				digest_process_messages(proc.stderr, progress)
+			#END handle progress
+			finalize_process(proc)
 		finally:
 			if prev_cwd is not None:
 				os.chdir(prev_cwd)

git/util.py

@@ -100,40 +100,6 @@ def get_user_id():
 	# END get username from login
 	return "%s@%s" % (username, platform.node())
 
-def _digest_process_messages(fh, progress):
-	"""Read progress messages from file-like object fh, supplying the respective
-	progress messages to the progress instance.
-
-	:return: list(line, ...) list of lines without linebreaks that did
-		not contain progress information"""
-	line_so_far = ''
-	dropped_lines = list()
-	while True:
-		char = fh.read(1)
-		if not char:
-			break
-
-		if char in ('\r', '\n'):
-			dropped_lines.extend(progress._parse_progress_line(line_so_far))
-			line_so_far = ''
-		else:
-			line_so_far += char
-		# END process parsed line
-	# END while file is not done reading
-	return dropped_lines
-
-def _finalize_proc(proc):
-	"""Wait for the process (clone, fetch, pull or push) and handle its errors accordingly"""
-	try:
-		proc.wait()
-	except GitCommandError,e:
-		# if a push has rejected items, the command has non-zero return status
-		# a return status of 128 indicates a connection error - reraise the previous one
-		if proc.poll() == 128:
-			raise
-		pass
-	# END exception handling
-
 #} END utilities
 
 #{ Classes