Submodule: Assured we properly convert paths to using the slash separator

Author: Byron

lib/git/objects/submodule/base.py

@@ -211,6 +211,12 @@ def add(cls, repo, name, path, url=None, branch=None, no_checkout=False):
 			path = path[:-1]
 		# END handle trailing slash
 
+		# assure we never put backslashes into the url, as some operating systems 
+		# like it ... 
+		if url != None:
+			url = to_native_path_linux(url)
+		#END assure url correctness
+		
 		# INSTANTIATE INTERMEDIATE SM
 		sm = cls(repo, cls.NULL_BIN_SHA, cls.k_default_mode, path, name)
 		if sm.exists():

test/git/test_submodule.py

@@ -378,7 +378,7 @@ def test_root_module(self, rwrepo):
 		assert not sm.module_exists()				# was never updated after rwrepo's clone
 
 		# assure we clone from a local source 
-		sm.config_writer().set_value('url', join_path_native(self.rorepo.working_tree_dir, sm.path))
+		sm.config_writer().set_value('url', to_native_path_linux(join_path_native(self.rorepo.working_tree_dir, sm.path)))
 		sm.update(recursive=False)
 		assert sm.module_exists()
 		sm.config_writer().set_value('path', fp)	# change path to something with prefix AFTER url change
@@ -406,7 +406,7 @@ def test_root_module(self, rwrepo):
 		#================
 		nsmn = "newsubmodule"
 		nsmp = "submrepo"
-		async_url = join_path_native(self.rorepo.working_tree_dir, rsms[0].path, rsms[1].path)
+		async_url = to_native_path_linux(join_path_native(self.rorepo.working_tree_dir, rsms[0].path, rsms[1].path))
 		nsm = Submodule.add(rwrepo, nsmn, nsmp, url=async_url)
 		csmadded = rwrepo.index.commit("Added submodule")
 		nsm.set_parent_commit(csmadded)
@@ -439,7 +439,7 @@ def test_root_module(self, rwrepo):
 		# to the first repository, this way we have a fast checkout, and a completely different 
 		# repository at the different url
 		nsm.set_parent_commit(csmremoved)
-		nsmurl = join_path_native(self.rorepo.working_tree_dir, rsms[0].path)
+		nsmurl = to_native_path_linux(join_path_native(self.rorepo.working_tree_dir, rsms[0].path))
 		nsm.config_writer().set_value('url', nsmurl)
 		csmpathchange = rwrepo.index.commit("changed url")
 		nsm.set_parent_commit(csmpathchange)