config.get_value: Added default argument including test

Author: Byron

lib/git/config.py

@@ -347,13 +347,21 @@ def read_only(self):
 		"""
 		return self._read_only
 
-	def get_value(self, section, option):
+	def get_value(self, section, option, default = None):
 		"""
+		``default``
+			If not None, the given default value will be returned in case 
+			the option did not exist
 		Returns
 			a properly typed value, either int, float or string
 		Raises TypeError in case the value could not be understood
+		Otherwise the exceptions known to the ConfigParser will be raised.
 		"""
-		valuestr = self.get(section, option)
+		try:
+			valuestr = self.get(section, option)
+		except Exception:
+			return default
+		
 		types = ( long, float )
 		for numtype in types:
 			try:

test/git/test_config.py

@@ -87,3 +87,8 @@ def test_base(self):
 		assert num_sections and num_options
 		assert r_config._is_initialized == True
 
+		# get value which doesnt exist, with default
+		default = "my default value"
+		assert r_config.get_value("doesnt", "exist", default) == default
+		
+