Do not use **kwargs for constructors.

It is better to have an explicit list of variables for the constructors,
be it only to avoid mispelled arguments.

Author: nud

lib/git/blob.py

@@ -14,29 +14,33 @@
 class Blob(object):
     DEFAULT_MIME_TYPE = "text/plain"
 
-    def __init__(self, repo, **kwargs):
+    def __init__(self, repo, id, mode=None, name=None):
         """
         Create an unbaked Blob containing just the specified attributes
 
         ``repo``
             is the Repo
 
-        ``atts``
-            is a dict of instance variable data
+        ``id``
+            is the git object id
+
+        ``mode``
+            is the file mode
+
+        ``name``
+            is the file name
 
         Returns
             GitPython.Blob
         """
-        self.id = None
-        self.mode = None
-        self.name = None
+        self.repo = repo
+        self.id = id
+        self.mode = mode
+        self.name = name
+
         self._size = None
         self.data_stored  = None
 
-        self.repo = repo
-        for k, v in kwargs.items():
-            setattr(self, k, v)
-
     @property
     def size(self):
         """

lib/git/commit.py

@@ -9,12 +9,13 @@
 
 from actor import Actor
 from lazy import LazyMixin
-import tree
+from tree import Tree
 import diff
 import stats
 
 class Commit(LazyMixin):
-    def __init__(self, repo, **kwargs):
+    def __init__(self, repo, id, tree=None, author=None, authored_date=None,
+                 committer=None, committed_date=None, message=None, parents=None):
         """
         Instantiate a new Commit
 
@@ -42,29 +43,29 @@ def __init__(self, repo, **kwargs):
         ``message``
             is the first line of the commit message
 
+        ``parents``
+            is the list of the parents of the commit
+
         Returns
             GitPython.Commit
         """
         LazyMixin.__init__(self)
 
         self.repo = repo
-        self.id = None
-        self.tree = None
-        self.author = None
-        self.authored_date = None
-        self.committer = None
-        self.committed_date = None
-        self.message = None
+        self.id = id
         self.parents = None
-
-        for k, v in kwargs.items():
-            setattr(self, k, v)
+        self.tree = None
+        self.author = author
+        self.authored_date = authored_date
+        self.committer = committer
+        self.committed_date = committed_date
+        self.message = message
 
         if self.id:
-            if 'parents' in kwargs:
-                self.parents = map(lambda p: Commit(repo, id=p), kwargs['parents'])
-            if 'tree' in kwargs:
-                self.tree = tree.Tree(repo, id=kwargs['tree'])
+            if parents is not None:
+                self.parents = [Commit(repo, p) for p in parents]
+            if tree is not None:
+                self.tree = Tree(repo, id=tree)
 
     def __bake__(self):
         temp = Commit.find_all(self.repo, self.id, max_count=1)[0]

lib/git/tree.py

@@ -9,17 +9,14 @@
 import blob
 
 class Tree(LazyMixin):
-    def __init__(self, repo, **kwargs):
+    def __init__(self, repo, id, mode=None, name=None):
         LazyMixin.__init__(self)
         self.repo = repo
-        self.id = None
-        self.mode = None
-        self.name = None
+        self.id = id
+        self.mode = mode
+        self.name = name
         self._contents = None
 
-        for k, v in kwargs.items():
-            setattr(self, k, v)
-
     def __bake__(self):
         # Ensure the treeish references directly a tree
         treeish = self.id