missing parenthesis error in javascript

Question

I am using this function:

function sel_test(e) {
  //alert(e.length-1);

  var splitdata = e.split("d");
  var newstr = e.substring(0,e.length-1);

  dropcall = 1;
  nodes = newstr.split(';');
  o = 0;
  if (nodes[0] == '1') o = nodes.shift();
  for (i=0;i<nodes.length;i++) {
    e = nodes[i];
    var ul = document.getElementById(e);
    if (icons) var img = document.getElementById(e+'i');
    if (ul) {
      if (((ul == 'none') AND (ul.style.display == 'none')) OR (ul.style.display == '')) {
        ul.style.display = 'block';
      } else if (!o) {
        ul.style.display = 'none';
      }
    }
  }

javascript is giving me an error of missing parenthesis:

if (((ul == 'none') AND (ul.style.display == 'none')) OR (ul.style.display == '')) {

what this the correct way of doing this.

If you don't get syntax errors from "AND" and "OR", then you must have a different version of javascript than I do. — Jeremy Goodell
– Jeremy Goodell, Commented May 30, 2012 at 0:12
@zhujy_8833: They're valid identifiers, but invalid operators, so even if they were defined as identifiers that could be resolved, JS would be looking for a semicolon to separate the statements. — user1106925
– user1106925, Commented May 30, 2012 at 0:15
Even after your edit, you're still missing the final right squiggly bracket to close the function. — Jeremy Goodell
– Jeremy Goodell, Commented May 30, 2012 at 0:17

Jeremy Goodell · Accepted Answer · 2012-05-30 00:21:41Z

4

You should be using && and || instead of AND and OR.

Shouldn't you?

edited May 30, 2012 at 0:21

answered May 30, 2012 at 0:09

Jeremy Goodell

19.1k5 gold badges37 silver badges54 bronze badges

Sign up to request clarification or add additional context in comments.

6 Comments

jbcedge Over a year ago

if i using && perl thows an error, adding inside an perl file

Jeremy Goodell Over a year ago

I thought you said this was javascript?

Daniele B Over a year ago

can you please post your answer instead of making a question?

Jeremy Goodell Over a year ago

You said this was javascript. (for the benefit of @Daniele B)

Jeremy Goodell Over a year ago

BTW @Daniele B, I tried to get in an answer on your fun question, but it was closed too quickly. I wanted to say that down voting and closing questions seem to be fun for many.

|

nnnnnn · Accepted Answer · 2012-05-30 00:16:54Z

3

Try this:

if (((ul == 'none') && (ul.style.display == 'none')) || (ul.style.display == ''))

JavaScript has an AND operator, but it isn't the word AND, it is && (also &, for a bitwise and). Similarly, rather than OR you want || (or | for bitwise).

Note that your ul variable will never be equal to the string 'none' - the return from document.getElementById(e) will always be either the matching DOM element, or null if no element has the supplied id.

Further reading: Logical Operators (and you should read it, because && and || don't always return true or false and MDN explains this).

edited May 30, 2012 at 0:16

answered May 30, 2012 at 0:08

nnnnnn

150k30 gold badges210 silver badges247 bronze badges

Comments

Jeremy Goodell · Accepted Answer · 2012-05-30 00:14:18Z

0

You are also missing the closing right squiggly for the function.

answered May 30, 2012 at 0:14

Jeremy Goodell

19.1k5 gold badges37 silver badges54 bronze badges

4 Comments

Jeremy Goodell Over a year ago

In addition, eclipse tells me that splitdata and img are never read, and i is not explicitly declared.

jbcedge Over a year ago

forget about splitdata, iam not using that

Jeremy Goodell Over a year ago

forgotten -- it's like I never saw it

Jeremy Goodell Over a year ago

The comment string had gotten so long on my other answer that I thought this deserved an answer of its own so that it wouldn't be missed.

Collectives™ on Stack Overflow

missing parenthesis error in javascript

3 Answers 3

6 Comments

Comments

4 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

6 Comments

Comments

4 Comments

Your Answer

Sign up or log in

Post as a guest

Related