java : Using Static Method for obtaining Database Connection

Question

I am working on an existing Java EE based application. This features the following method for connecting to a database :

public static java.sql.Connection connectionToDataBase(String jndiName,boolean flag)throws Exception 
{
DataSource ds =(javax.sql.DataSource) initCtx.lookup(jndiName);
return ds.getConnection();
    } catch (NamingException ne) {
            throw ne;
        } finally {
            try {
                if (initCtx != null)
                    initCtx.close();
            } catch (NamingException ne) {

                throw ne;
            }
        }
}

My question is whether using a static method for connecting to a database is correct?

There is nothing wrong with using a static method to connect to a database. — Hans Z
– Hans Z, Commented Jul 13, 2012 at 13:59
I did not posted the whole method code , so some part might is missing , the only intention of this question is using Static Method for getting DB Connection is valid or not . — Pawan
– Pawan, Commented Jul 13, 2012 at 14:07
@gobernador: That's not quite true. The finally block will alway run. (see the JLS) — ig0774
– ig0774, Commented Jul 13, 2012 at 14:11
@ig0774 You're right, I didn't know that. Well, you learn something every day. — gobernador
– gobernador, Commented Jul 13, 2012 at 14:13

Chris Dargis · Accepted Answer · 2012-07-13 19:33:56Z

4

Why have you defined the function as static?

It is not incorrect nor is there any convention that would prohibit you in calling a static method from a non-static one. By definition, a non-static method belongs to an instance of the class, whereas a static method belongs to the class itself.

Having a static method simply means you don't need an instance of the class to connect to the DB.

To answer your question, you probably want to consider what the class encapsulates. Do you only want an instance of the class to be able to connect to the DB? Or would you like to be able to connect to the DB without a reference to an instance of the class?

edited Jul 13, 2012 at 19:33

answered Jul 13, 2012 at 14:06

Chris Dargis

6,0634 gold badges42 silver badges66 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Grim · Accepted Answer · 2012-07-13 14:15:45Z

0

If you can use a Connection-Pool or an Entity-Manager you better use them!

answered Jul 13, 2012 at 14:15

Grim

2,15312 gold badges63 silver badges139 bronze badges

Collectives™ on Stack Overflow

java : Using Static Method for obtaining Database Connection

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related