array with 1 element causing error in for loop

Question

I'm using the array length as the test condition in my for loop. But if there is only one element in the array, I receive an 'Index was outside the bounds of the array' error. What am I doing wrong? Thanks.

string templateList;
string[] template;

string sizeList;
string[] size;

templateList = textBox1.Text;
template = templateList.Split(',');

sizeList = textBox2.Text;            
size = sizeList.Split(',');

for (int i = 0; i <= template.Length; i++)
{
    for (int j = 0; j < size.Length; j++)
    {
         //do something with template[i] and size[j]
    }
}

the values are coming from a textBox, the user may only enter one value. In which case it would only need to run once.

You would probably be better served using foreach. Index math is really a waste of time in C#. — Ryan Gates
– Ryan Gates, Commented Dec 11, 2012 at 15:44

Adil · Accepted Answer · 2012-12-11 15:45:09Z

5

Array is zero-based index, i.e first element has zero index. template[0] points first element. When you have only one element template[1] will refer to second element which is not present and you will probably get out of index exception.

Change

for (int i = 0; i <= template.Length; i++)

To

for (int i = 0; i < template.Length; i++)

edited Dec 11, 2012 at 15:45

answered Dec 11, 2012 at 15:38

Adil

148k25 gold badges217 silver badges207 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Lance U. Matthews · Accepted Answer · 2012-12-11 15:42:47Z

1

Using...

for (int i = 0; i <= template.Length; i++)

...on the last iteration i will equal template.Length. template[template.Length] will always result in an IndexOutOfRangeException. Since the last element of template actually has index template.Length - 1, you should instead use...

for (int i = 0; i < template.Length; i++)

answered Dec 11, 2012 at 15:42

Lance U. Matthews

16.8k6 gold badges52 silver badges71 bronze badges

Comments

Luca Davanzo · Accepted Answer · 2012-12-11 15:41:33Z

0

Count start from zero, you have to change your first for statement into:

for (int i = 0; i < template.Length; i++) {....}

answered Dec 11, 2012 at 15:41

Luca Davanzo

21.6k15 gold badges124 silver badges152 bronze badges

Collectives™ on Stack Overflow

array with 1 element causing error in for loop

3 Answers 3

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related