Trouble with while loop in python function

Question

I have a small app that asks for a movie. When the rating is over 50, return watch it. If it doesn't, choose another movie. Though when I get to the condition in movieDec, it won't go back to the top of the function to calculate the score of the movie. Can't figure this one out.

def getScore():
   choose = raw_input("pick a movie ")
   rt = RT()
   info = rt.search(choose)
   rating1 = info[0].get('ratings').get('critics_score')
   rating2 = info[0].get('ratings').get('audience_score')
   stars = (rating1 + rating2) / 2
   return rating1, rating2, stars


def movieDec():
   critic, aud, stars = getScore()
   print 'Critics gave it a %s' %critic
   print 'Audiences gave it a %s' %aud
   print 'The average rating is %s' %stars
   while stars < 50:
       print "That's no good, pick again"
       getScore()
    print 'Good choice.'

user1640263 · Accepted Answer · 2013-02-16 14:22:26Z

2

You are not updating the stars variable in the loop. Try:

while stars < 50:
   print "That's no good, pick again"
   critic, aud, stars = getScore()

answered Feb 16, 2013 at 14:22

user1640263

Sign up to request clarification or add additional context in comments.

Comments

NPE · Accepted Answer · 2013-02-16 14:21:49Z

0

In your loop, you are ignoring the return value of getScore():

   getScore()

Change that to:

   critic, aud, stars = getScore()

answered Feb 16, 2013 at 14:21

NPE

503k114 gold badges970 silver badges1k bronze badges

Comments

Community · Accepted Answer · 2017-05-23 10:24:51Z

0

this corrected code above would call getScore() function 2nd time (if stars <50) but then it won't display the scores until the loop looks like:

while stars < 50:
   print "That's no good, pick again"
   critic, aud, stars = getScore()
   print 'Critics gave it a %s' %critic
   print 'Audiences gave it a %s' %aud
   print 'The average rating is %s' %stars

edited May 23, 2017 at 10:24

CommunityBot

11 silver badge

answered Feb 16, 2013 at 14:31

arcolife

4361 gold badge4 silver badges12 bronze badges

1 Comment

Rushy Panchal Over a year ago

Instead of printing the whole thing again, you could just call movieDec() again.

Collectives™ on Stack Overflow

Trouble with while loop in python function

3 Answers 3

Comments

Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related