TypeError: Cannot find function When using Array.prototype

Question

I have a very simple function I am trying to add to an array. I have seen examples on this site where people have extended different simple items, like String & Array. But I also have seen comments where Google doesn't allow you to extend certain classes. But from what I can tell, that was only for custom Google classes, like Spreadsheet, Range, etc.

Why is this throwing a TypeError? Tried to use the same function I found here.

Array.prototype.findIndex = function(search){
  if(search == "") return false;
  for (var i=0; i<this.length; i++)
    if (this[i] == search) return i;

  return -1;
} 

//Do a search on a specific range, find the correct ID, and do a lookup based on ID
function onEdit(e) {
  var e = {};
  e.value = "Test String";
  var client = e.value;
  var columnValues = mydoc.getRangeByName(categoryRangeName).getValues();

  //columnValues returns 2D array of values
  //https://developers.google.com/apps-script/reference/spreadsheet/range#getValues()
  var searchResult = columnValues.findIndex(e.value);  //**ERROR HERE**

}

UPDATE

I will also add, that I set the method to just return a value like this just to test that there was no problem with the prototype, and it failed on the same error.

Array.prototype.findIndex = function(val) {
  return val;
}

And I created a function with the same for loop, and it works just fine.

function findIndex(vals, search) {
  if(search == "") return false;
  for (var i=0; i<vals.length; i++)
    if (vals[i] == search) return i;

  return -1;
}

wchiquito · Accepted Answer · 2013-12-08 19:20:13Z

2

The findIndex function, search on a 1D array, however, you have a 2D array. You must change the findIndex function to search on a 2D array.

Array.prototype.findIndex = function(search) {
  if(search === '') return false;
  for (var i = 0, len = this.length; i < len; i++)
    if (this[i] === search) return i;
  return -1;
}

function onEdit(e) {
  var search_text = 'Test String';
  var columnValues1D = ['String Test', 'Test String'];
  var columnValues2D = [['String Test'], ['Test String']];
  Logger.log(columnValues1D.findIndex(search_text)); // <-- 1
  Logger.log(columnValues2D[0].findIndex(search_text)); // <-- -1
  Logger.log(columnValues2D[1].findIndex(search_text)); // <-- 0
}

UPDATE

Array.prototype.findIndex = function(search) {
  if(search === '') return false;
  for (var i = 0, len = this.length; i < len; i++)
    if (this[i][0] === search) return i;
  return -1;
}

function onEdit(e) {
  var search_text = 'Test String';
  var columnValues2D = [['String Test'], ['Test String']];
  Logger.log(columnValues2D.findIndex(search_text)); // <-- 1
}

edited Dec 8, 2013 at 19:20

answered Dec 8, 2013 at 16:58

wchiquito

16.6k2 gold badges37 silver badges46 bronze badges

Sign up to request clarification or add additional context in comments.

7 Comments

Nathan Over a year ago

That's what I thought too. But I created a findIndex function, and passed in my 2D array and search value, and the exact same for loop found a match and worked? Updating my question.

wchiquito Over a year ago

@Nathan: The new findIndex() function, which is not added/injected into the Array prototype does a search on a 2D array.

Nathan Over a year ago

So why does the method still error/fail when I just have it return val; ?

wchiquito Over a year ago

@Nathan: I do not understand what you said with the return val;. The updated answer you can see the findIndex() function to search a 2D array.

Nathan Over a year ago

Thanks. I think my problem lies elsewhere. I put your code in my current script, and it failed. But I created a completely blank one and only pasted in your code, and it worked. I will figure out where my problem lies. Thanks!

|

Collectives™ on Stack Overflow

TypeError: Cannot find function When using Array.prototype

1 Answer 1

7 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

7 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related