Java: Binary Tree Node displaying only memory addresses or null

Question

I have a node class and am just trying to narrow down an issue when adding elements to my tree. I think my node class is just not properly creating the node to add in the tree. When I print each node, it is returning memory addresses, I believe. I cannot seem to get it to print anything else. Any help in determining if my node class is faulty would be great.

Example of what my program prints:

([C@f72003d)
([C@56dacb7)
([C@63662529)
([C@4711d9ba)

The TreeNode class:

public class TreeNode {

char[] data;
TreeNode left, right, parent;
// used for printing:
int column;
int row;
int center;


public TreeNode(char[] data) {
    this.data = data;
    left = right = parent = null;
}

@Override
public String toString() {
    return "(" + data + ")";
}
public int return_letter(){
    char x = data[0];
    int b = Character.getNumericValue(x);
    return b;        
}

public int findMaxDepth() {
    int lmax = 0;
    int rmax = 0;
    if (left != null) {
        lmax = left.findMaxDepth();
    }
    if (right != null) {
        rmax = right.findMaxDepth();
    }
    return 1 + Math.max(lmax, rmax);
}

}

You haven't really described your issue... please provide us with more information. A short but complete program demonstrating the problem would be helpful. — Jon Skeet
– Jon Skeet, Commented Mar 29, 2014 at 19:34
could you please post whatever error message you are getting? — mistahenry
– mistahenry, Commented Mar 29, 2014 at 19:34
@Override public String toString() {return "(" + data + ")";} will not print what you want. Use Arrays.toString(data) to get a String representation of the content of your array. — Alexis C.
– Alexis C., Commented Mar 29, 2014 at 19:35

mistahenry · Accepted Answer · 2014-03-29 19:41:30Z

1

public String toString() {
    return "(" + data + ")";
}

You're problem is here. toString() is returning the memory references of data and its contained elements. You can either use Arrays.toString(data) inside this method to get a string representation of the items in the array, or in your method that is printing out the data, do something like this:

for(int i = 0; i < data.length; i++){
    println(data[i]);
}

answered Mar 29, 2014 at 19:41

mistahenry

8,7343 gold badges29 silver badges40 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Java: Binary Tree Node displaying only memory addresses or null

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related