Onkeydown not working javascript

Question

Here is my code

document.onkeydown = function (a) {
    if (a.which == 13) {
        alert("Not Anymore");

    }
}

document.onkeydown = function (b) {
    if (b.which == 65) {
        auto();
    }
}

document.onkeydown = function (c) {
    if (c.which == 83) {
        auto2();

    }
}

Only the last snippet works can someone explain why this is happening check my website and you can see it isnt working when you press a but when you press b it is

Thanks, I appreciate the help and feedback

The event handlers are overriden by the last, so only the last works — Tushar
– Tushar, Commented Sep 14, 2015 at 3:33
document.addEventListener(…); would be another option. — Sebastian Simon
– Sebastian Simon, Commented Sep 14, 2015 at 3:39

Tushar · Accepted Answer · 2015-09-14 03:42:28Z

5

You're binding the same event on the document multiple times. So, the later event handlers override the previous event handlers just like the functions with same name does. You need to bind only one event handler and use if... else in it.

You can use this

document.onkeydown = function (e) {
    if (e.which == 13) {
        alert("Not Anymore");
    } else if (e.which == 65) {
        auto();
    } else if (e.which == 83) {
        auto2();
    }
};

Also, use addEventListener instead of onkeydown.

document.addEventListener('keydown', function (a) {
    if (a.which == 13) {}
    ...
}, false);

edited Sep 14, 2015 at 3:42

answered Sep 14, 2015 at 3:34

Tushar

87.4k21 gold badges164 silver badges182 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Kevin Kuyl Over a year ago

To expand on this, nowadays its a common best practice to use event listeners; document.addEventListener('keydown', function(e){})

Tushar Over a year ago

@DuncanMilrad You're welcome! If your problem is solved, kindly accept the answer

Collectives™ on Stack Overflow

Onkeydown not working javascript

1 Answer 1

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related