ASP.NET how to select checkbox list items with comma separated string

Question

I have a checkedlistBox cblHobbies

StringBuilder hobbies = new StringBuilder(string.Empty);
foreach (ListItem li in cblHobbies.Items) {
    if (li.Selected) {
        hobbies.Append(li).Append(", ");
    }
}
string hobby = hobbies.ToString().TrimEnd(' ').TrimEnd(',');

I am storing hobby in SQL Server database as Varchar(MAX).

When the user edit his profile i want all the hobbies get selected already.

My Question is how to select checklistbox items from a comma separated list efficiently? (in respect of number of iterations)

Fyi, a nicer way: string hobby=String.Join(", ", cblHobbies.Items.Cast<ListItem>().Where(i=>i.Selected)); — Tim Schmelter
– Tim Schmelter, Commented Mar 1, 2016 at 14:38
But never store multiple informations in one value in your database. Instead store every selected item in it's own record. So this comma separated string does not belong in the database. — Tim Schmelter
– Tim Schmelter, Commented Mar 1, 2016 at 14:41
However, aren't you mirco optimizing things? What are you trying to optimize at all? If you have read the value from database you can use a simple loop to select them. It's extremely efficient. — Tim Schmelter
– Tim Schmelter, Commented Mar 1, 2016 at 14:46
Ok well i thought it can't be optimized much as well. No worries. Thanks @Tim. But i am having trouble deducing code for selecting it from text without using if else. — Abhilash Srivastava
– Abhilash Srivastava, Commented Mar 1, 2016 at 14:51

Tim Schmelter · Accepted Answer · 2016-03-01 14:55:35Z

Summarizing my comments:

You can use following readable one-liner instead of your StringBuilder-loop:

string hobby = String.Join(", ", cblHobbies.Items.Cast<ListItem>()
                                           .Where(i=> i.Selected));

Never store multiple informations in one value in your database. Instead store every selected item in it's own record. So this comma separated string does not belong there. Normalize your Database.
- That's much more efficient
- allows easier queries
- avoids corrupt data
- etc. ...

However, aren't you mirco optimizing things? If you have read the value from database you can use a simple loop to select them. It's very efficient.

string hobby = GetHobbyFromDB();
string[] hobbies = hobby.Split(new []{", "}, StringSplitOptions.None);

foreach (ListItem li in cblHobbies.Items)
    li.Selected = hobbies.Contains(li.Text);

Collectives™ on Stack Overflow

ASP.NET how to select checkbox list items with comma separated string

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related