JS function with jquery always return undefined

Question

I am building a Js function with Jquery checking if certain inputs are empty or not for validation. Here's the function that checks if the inputs are empty or not:

   function isValid(elements){
      var validation = false
      elements.each(function() {
        if ($( this ).val().length > 0){
          validation = true
        }
        else {
          validation
        }
      });
      validation
    }

however whatever I do my function returns undefined and never the boolean value that is supposed to be contained in the validation variable ?

What should I do for my function to return true or false ?

What do you think validation lines are doing? Your logic is also flawed. The validation is most likely not doing what you want it to do. — epascarello
– epascarello, Commented Jul 26, 2016 at 15:53
indeed I thought the my last validation was returning my boolean value but now I understand I need to use return — David Geismar
– David Geismar, Commented Jul 26, 2016 at 17:05

Olivier Boissé · Accepted Answer · 2016-07-26 15:43:51Z

2

You can return false if at least one element is empty, otherwise return true.

function isValid(elements){
  var validation = true;

  elements.each(function() {
    if ($( this ).val().trim().length === 0){
      validation = false;
    }
  });

  return validation;
}

edited Jul 26, 2016 at 15:43

answered Jul 26, 2016 at 15:39

Olivier Boissé

18.5k7 gold badges54 silver badges70 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Rajaprabhu Aravindasamy Over a year ago

return false inside of each would act as a breaking statement

Rory McCrossan Over a year ago

You may also want to add a trim() in the length check, otherwise filling the field with spaces would be valid

Rajaprabhu Aravindasamy · Accepted Answer · 2016-07-26 15:44:07Z

2

You can do your code like below by using Array#some,

function isValid(elements) {
 return !Array.from(elements).some(function(itm){ itm.value.trim().length == 0 });
}

You are not at all returning anything from the function, that means as a default returning value undefined will be returned.

answered Jul 26, 2016 at 15:44

Rajaprabhu Aravindasamy

67.2k17 gold badges107 silver badges133 bronze badges

Comments

Community · Accepted Answer · 2017-05-23 11:53:52Z

2

Your function isValid() is returning undefined because this is the expected behaviour in JavaScript: undefined is the “default” returned value if a function does not specify one returned value, and your function isValid() doesn't have any return.

Check this answer.

edited May 23, 2017 at 11:53

CommunityBot

11 silver badge

answered Jul 26, 2016 at 15:37

Gerardo Furtado

102k9 gold badges128 silver badges178 bronze badges

Collectives™ on Stack Overflow

JS function with jquery always return undefined

3 Answers 3

2 Comments

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

2 Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related