SyntaxError: invalid syntax in URLpattern

Question

hi am getting a syntax error

url:

url(r'^reset-password/$',
    PasswordResetView.as_view(template_name='accounts/reset_password.html', 'post_reset_redirect': 'accounts:password_reset_done'), name='reset_password'),

What is the problem?

thanks

You used a colon in 'post_reset_redirect': 'accounts:password_reset_done', instead of post_reset_redirect='accounts:password_reset_done'. — willeM_ Van Onsem
– willeM_ Van Onsem, Commented Sep 25, 2018 at 20:08

willeM_ Van Onsem · Accepted Answer · 2018-09-25 20:19:40Z

3

The problem is that you mix dictionary syntax with parameter syntax:

url(
    r'^reset-password/$',
    PasswordResetView.as_view(
        template_name='accounts/reset_password.html',
        'post_reset_redirect': 'accounts:password_reset_done'
    ),
    name='reset_password'
)

This syntax with a colon, is used for dictionaries. For parameters, it is identifier=expression, so:

from django.urls import reverse_lazy

url(
    r'^reset-password/$',
    PasswordResetView.as_view(
        template_name='accounts/reset_password.html',
        success_url=reverse_lazy('accounts:password_reset_done')
    ),
    name='reset_password'
)

The post_reset_redirect has been removed as parameter, but the success_url performs the same functionality: it is the URL to which a redirect is done, after the POST request has been handled successfully.

The wrong syntax probably originates from the fact that when you used a function-based view, you passed parameters through the kwargs paramter, which accepted a dictionary.

The class-based view however, obtains these parameter through the .as_view(..) call. Furthermore class-based views typically aim to generalize the process, and there the success_url, is used for FormViews.

edited Sep 25, 2018 at 20:19

answered Sep 25, 2018 at 20:10

willeM_ Van Onsem

482k33 gold badges483 silver badges624 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

JosephS Over a year ago

thanks im getting this error now: TypeError: PasswordResetView() received an invalid keyword 'post_reset_redirect'. as_view only accepts arguments that are already attributes of the class.

JosephS Over a year ago

when I do that I get a syntax error with my urlpattern closing bracket ]...i tried )) at end of urlpattern but then i get 'NameError: name 'reverse_lazy' is not defined

willeM_ Van Onsem Over a year ago

@JosephS: no, yyou need to import it: from django.urls import reverse_lazy.

willeM_ Van Onsem Over a year ago

The brackets are - afaik - correct (note that we colose both of them, one at the line in boldface, and one at the next line).

Collectives™ on Stack Overflow

SyntaxError: invalid syntax in URLpattern

1 Answer 1

4 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

4 Comments

Your Answer

Sign up or log in

Post as a guest

Related