Problem rewriting dynamic URLs using mod_rewrite

Question

I'm trying to rewrite a dynamic URL using the following code:

RewriteRule (.*)/$ index.php?location=$1  
RewriteRule (.*)/(.*)/$ index.php?location=$1&company=$2

I really need two rewrites as you can see from the above code. First, I need the page to rewrite just the location if that's all there is. For example, it would turn site.ccom/index.php?location=sandiego into site.com/sandiego/
This is working correctly.

However, when I try to add in the second variable it fails. It manages to detect the &company=1 variable, but for some reason it returns the ?location=sandiego variable as 'index.php'. For example, if I input the following: site.com/san-diego/1/ and then try to grab the $location and $company variables, it will only get the $company variable successfully, and the $location variable will be set to 'index.php', rather than 'san-diego'.

Any help would be greatly appreciated.

Jeremy · Accepted Answer · 2011-03-23 23:05:08Z

1

I think I found the solution. I'm using the following:

RewriteRule ^([a-z0-9-]+)/?$ index.php?location=$1 [NC]
RewriteRule ^([a-z0-9-]+)/([a-z0-9-]+)/?$ index.php?location=$1&company=$2 [NC]

This seems to be working perfectly, and is successfully redirecting both site.com/sandiego/ and site.com/sandiego/1/

answered Mar 23, 2011 at 23:05

Jeremy

1,1715 gold badges20 silver badges31 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Maxime Pacary · Accepted Answer · 2011-03-23 22:07:20Z

0

Try those:

RewriteRule ^([a-z0-9]+)/?$    index.php?location=$1 [NC]
RewriteRule ^([a-z0-9]+)/([a-z0-9]+)/?.*$    index.php?location=$1&company=$2 [NC]

Keep in mind that trying to capture any sequence of characters (by using for example (.*) or (.+)) when doing URL rewriting, is usually a bad idea, as explained in this thread : http://www.sitepoint.com/forums/apache-configuration-199/rewrite-eliminate-trailing-slash-arbitrary-parameters-520302.html#post3657601

edited Mar 23, 2011 at 22:07

answered Mar 23, 2011 at 21:42

Maxime Pacary

23.2k12 gold badges92 silver badges117 bronze badges

3 Comments

Jeremy Over a year ago

Sorry, neither of those work at all. They both returned with 404 errors.

Maxime Pacary Over a year ago

Sorry, I've renamed index.php to rewrite.php for testing and forgot to change that back... => edited my answer.

Jeremy Over a year ago

Yeah, a figured that, and renamed to index.php. It still doesn't work however. Going back to my original code, I can get either one or the other to work. If I just use this line: RewriteRule (.*)/$ index.php?location=$1 it redirects site.com/sandiego/ perfectly. And if I use just this line: RewriteRule (.*)/(.*)/$ index.php?location=$1&company=$2 it redirects to site.com/sandiego/1/ perfectly. However, when I use them together it all breaks down.

Naraen · Accepted Answer · 2011-03-23 23:02:08Z

0

Try  ([^\/]*)/([^\/]*)/$  instead of (.*)/(.*)/$

answered Mar 23, 2011 at 23:02

Naraen

3,2502 gold badges25 silver badges20 bronze badges

1 Comment

Jeremy Over a year ago

Thanks for your response, but I think I've solved the problem (posted below). I will get back to you if my solution doesn't work, and will test your approach. Thanks again.

Collectives™ on Stack Overflow

Problem rewriting dynamic URLs using mod_rewrite

3 Answers 3

Comments

3 Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

3 Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related