Working with Javascript elements

Question

I have some google map markers that sit on a map. They are controlled by the rout-markers id. When I do this command:

document.getElementById('rout_markers').style.display = 'none';

I am able to make all existing markers disappear from the map, which is what I want. But if new markers are added, I am not able to add them to the rout_markers element by doing this:

document.getElementById('rout_markers').value = str;

I mean, the markers do appear on the map, just not in the rout_markers id and I can't pass them to the request when I need to. Is there some way I can get the newly-created markers to get attached to the rout_markers id again?

Is this a generally accepted method of doing things in JS still?

Thanks, Alex

You'll need to post your HTML, I think, because this doesn't make much sense. One thing to note: "id" values really must be unique on a page - if you re-use an "id" for more than one element, your page is invalid. The "class" attribute is what you should use to give elements a "type" or "category" (or, I guess, a "class" :-) — Pointy
– Pointy, Commented Apr 10, 2011 at 20:10

Fatih Acet · Accepted Answer · 2011-04-10 20:22:06Z

1

you should collect all markers in an object with known keys then find the marker then do what you want to do.

I think, you should have

markers Object that holds all markers in the map
addMarkerToMap Function that adds new marker to map
getMarker Function that gets a marker

and the codes should be like this

var markers = {}

var addMarkerToMap = function(id) {
    var marker = ... // create a new marker and set given id argument as marker id and append marker to map
    markers[id] = marker; // this will inject the created marker to markers Object
}

var getMarker = function(id) {
    return markers[id];
}

answered Apr 10, 2011 at 20:22

Fatih Acet

29.8k9 gold badges55 silver badges58 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Working with Javascript elements

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related