Parsing a json, loop and print (python)

Question

I am new to python or JSON. I do a request to an API, can reach the data and print all the data that I need. The problem is : I print only one element, i would like to print all the loop.

import json
from urllib.request import urlopen

with urlopen("myapiurl") as response: source = response.read()

data = json.loads(source)


for item in data ["resultsPage"]["results"]["calendarEntry"]:
    artistname = item["event"]["displayName"]
    hour = item["event"]["start"]["time"]
    day = item["event"]["start"]["date"]
    oid = item["event"]["id"]
    venue = item["event"]["venue"]["displayName"]
    newJson = (
     {oid:{
      'artist': artistname,
      'hour': hour,
      'day': day,
      'location': venue,
      'description': "",
      'expires': 1,}
     })

    with open('concert.json', 'w') as json_file:
        json.dump(newJson, json_file, sort_keys=True, indent=2)

Let me know if you need the api url. Thanks !

Can you fix the indentation after the for loop? If the writing of the file happens outside the loop then you will only be writing one file. If you are doing multiple opens, writes, closes to the same file then it should be opened in append mode ('a' instead of 'w'). — SyntaxVoid
– SyntaxVoid, Commented Aug 7, 2019 at 17:14
I changed 'w' to 'a' but now the last item of the loop is print two times. Could you explain the first part of your answer ? Thanks — user9406886
– user9406886, Commented Aug 7, 2019 at 17:24
In the code you posted, there is no indentation after you begin the for loop. There is also no indentation after the with statement at the bottom. As it is, this code won't even run and will raise an IndentationError. In other words, it's hard to see where your for loop ends. — SyntaxVoid
– SyntaxVoid, Commented Aug 7, 2019 at 17:49

Bhavesh Gupta · Accepted Answer · 2019-08-07 18:06:17Z

1

I would suggest you to try this with opening and closing file only once.

import json
from urllib.request import urlopen

with urlopen("myapiurl") as response: source = response.read()

data = json.loads(source)

newJsonx=dict()
for item in data ["resultsPage"]["results"]["calendarEntry"]:
    artistname = item["event"]["displayName"]
    hour = item["event"]["start"]["time"]
    day = item["event"]["start"]["date"]
    oid = item["event"]["id"]
    venue = item["event"]["venue"]["displayName"]

    newJson = (

     {oid:{
      'artist': artistname,
      'hour': hour,
      'day': day,
      'location': venue,
      'description': "",
      'expires': 1,
     }
     })
    newJsonx.update(newJson)



with open('concert.json', 'w') as json_file:
    json.dump(newJsonx, json_file, sort_keys=True, indent=2)

answered Aug 7, 2019 at 18:06

Bhavesh Gupta

329 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Parsing a json, loop and print (python)

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related