AssertionError: `create()` did not return an object instance

Question

I am getting the error below while sending a request to a UserRegisterView:

  File "/Users/MichaelAjanaku/Desktop/test/afrocode/lib/python3.6/site-packages/rest_framework/views.py", line 506, in dispatch
    response = handler(request, *args, **kwargs)
  File "/Users/MichaelAjanaku/Desktop/test/leave/views.py", line 22, in post
    serializer.save()
  File "/Users/MichaelAjanaku/Desktop/test/afrocode/lib/python3.6/site-packages/rest_framework/serializers.py", line 207, in save
    '`create()` did not return an object instance.'
AssertionError: `create()` did not return an object instance.

I don't know why such occurs. Here is my views.py:

class UserRegistrationView(CreateAPIView):
    serializer_class = UserRegistrationSerializer
    permission_classes = (AllowAny,)

    def post(self, request):
        serializer = self.serializer_class(data= request.data)
        serializer.is_valid(raise_exception=True)
        serializer.save()
        status_code = status.HTTP_201_CREATED
        response = {
            'success' : 'True',
            'status code' : status_code,
            'message' : 'User registered successfully'
        }

and the serializers:

class UserRegistrationSerializer(serializers.ModelSerializer):

    profile = UserSerializer(required=False)
    class Meta:
        model = User
        fields = ('email', 'password','profile' )
        extra_kwargs = {'password': {'write_only' : True}}

    
    def create(self, validated_data):
        profile_data = validated_data.pop('profile')
        user = User.objects.create_user(**validated_data)
        UserProfile.objects.create(
            user = user,
            first_name = profile_data['first_name'],
            last_name= profile_data['last_name'],
                     )

Please what is causing the error? Thanks

Joseph · Accepted Answer · 2021-01-23 22:10:02Z

7

Your create method is not returning an object instance. You should return the result of the User.objects.create(...) call.

def create(self, validated_data):
    profile_data = validated_data.pop('profile')
    user = User.objects.create_user(**validated_data)
    UserProfile.objects.create(
        user = user,
        first_name = profile_data['first_name'],
        last_name= profile_data['last_name'],
                 )
    return user

answered Jan 23, 2021 at 22:10

Joseph

13.3k21 gold badges80 silver badges117 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

jordy bayo · Accepted Answer · 2021-07-15 11:57:17Z

0

you did not return the user in your create method.

class UserManager(BaseUserManager):

def create_user(self, username, email, password=None):
    if username is None:
        raise TypeError('User should have a username')
    if email is None:
        raise TypeError('User should have an email')

    user = self.model(username=username, email=self.normalize_email(email))
    user.set_password(password)
    user.save()
    return user

answered Jul 15, 2021 at 11:57

jordy bayo

4594 silver badges3 bronze badges

Comments

Random User · Accepted Answer · 2021-12-11 19:49:53Z

0

I had the same error too. In your serializer.py : at the top add:

from django.contrib.auth import get_user_model
User = get_user_model()

This worked for me as I was using a custom user.

edited Dec 11, 2021 at 19:49

answered Dec 11, 2021 at 19:41

Random User

6212 gold badges11 silver badges24 bronze badges

Collectives™ on Stack Overflow

AssertionError: `create()` did not return an object instance

3 Answers 3

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related