PHP notice - Undefined index on index.php

Question

I'm running into a server notice that doesn't seem to effect the loading of my pages but nonetheless creates a new entry in the error log every time a page is loaded... That error is: PHP Notice: Undefined index: thing in C:\File Location\htdocs\index.php on line 1

I'm not sure whether the problem is actually on the first line or on a subsequent line, so I included a modified version of the whole file. The weird thing for me is that there's an identical line of code on several other files and it doesn't raise an issue in them. Also, the value is correctly extracted and all is well, I just don't know what to change in order to avoid the notice.

$thingvalue = $_REQUEST['thing'];

include("mdetect.php");

  $iphoneTierHomePage = 'mobilemain.php';
  $iphoneTierMobilePage = 'mobilepage.php?thing=' . $thingvalue;
  $genericMobileDeviceHomePage = 'mobilemain.php';
  $genericMobileDeviceMobilePage = 'mobilepage.php?thing=' . $thingvalue;
  $line1 = define('WP_USE_THEMES', true);
  $line2 = require('./wp-blog-header.php');
  $desktopPage == $line1 + $line2;

  $uagent_obj = new uagent_info();

  function AutoRedirectToProperHomePage()
  {
  global $thingvalue, $uagent_obj, $iphoneTierHomePage, $genericMobileDeviceHomePage, $iphoneTierMobilePage, $genericMobileDeviceMobilePage, $desktopPage;

  if ($thingvalue == ''){

      if ($uagent_obj->isTierIphone == $uagent_obj->true) 
      header ('Location: '.$iphoneTierHomePage);

      else if ($uagent_obj->DetectMobileQuick() == $uagent_obj->true) 
      header ('Location: '.$genericMobileDeviceHomePage);

      else
      header ('Location: '.$desktopHomePage);
    }
    if ($thingvalue != ''){
        if ($uagent_obj->isTierIphone == $uagent_obj->true) 
        header ('Location: '.$iphoneTierMobilePage);

        else if ($uagent_obj->DetectMobileQuick() == $uagent_obj->true) 
        header ('Location: '.$genericMobileDeviceMobilePage);

        else
        header ('Location: '.$desktopPage);
    }
  }

AutoRedirectToProperHomePage();

Type this in the second line and see what it gets you: var_dump($_REQUEST['thing']) — Nabeel
– Nabeel, Commented Aug 22, 2011 at 4:41

Doug Kress · Accepted Answer · 2011-08-22 04:40:50Z

4

It's referring to the array index for the first line in index.php: Try this:

$thingvalue = empty($_REQUEST['thing']) ? '' : $_REQUEST['thing'];

answered Aug 22, 2011 at 4:40

Doug Kress

3,5471 gold badge15 silver badges19 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

tylerl Over a year ago

Once again, I'm blown away by this community! Thank you so much, Doug!

SeanCannon · Accepted Answer · 2011-08-22 06:28:06Z

1

It is trying to reference the index thing inside the $_REQUEST superglobal. If someone is viewing that page directly and was not posted via a form or directed with a ?thing=foobar in the query string, PHP will show that notice. I'd recommend not using $_REQUEST as it checks both $_GET and $_POST which is not very secure/practical - then check if it is set, and if not, taking some failsave action:

try
{
    if(!isset($_POST['thing']))
    {
        throw new Exception('No direct access. Please use our <a href="http://www.mysite.com/contact">Contact form</a>');
    }
    else
    {
        $thingvalue = $_POST['thing'];
    }
}
catch(Exception $e)
{
    echo $e->getMessage();
    exit();
}

edited Aug 22, 2011 at 6:28

answered Aug 22, 2011 at 4:46

SeanCannon

78.1k17 gold badges126 silver badges145 bronze badges

Comments

Matt R. Wilson · Accepted Answer · 2011-08-22 04:42:10Z

0

The issue is that you are trying to get the value of thing here $thingvalue = $_REQUEST['thing']; before checking if the value exists first.

try this first

if( !isset( $_REQUEST['thing']) )
{
  do something because its missing
}

answered Aug 22, 2011 at 4:42

Matt R. Wilson

7,5955 gold badges35 silver badges51 bronze badges

Collectives™ on Stack Overflow

PHP notice - Undefined index on index.php

3 Answers 3

1 Comment

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

1 Comment

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related