Binary Tree Insertion Pointer Issue

Question

I have two functions in a class that creates a binary tree:

void Btree::insertNode(node* r, node* newNode){
    if (r == NULL)
        r = newNode;
    else if (greater(root, newNode))
        insertNode(r->left, newNode);
    else
        insertNode(r->right, newNode);
}

void Btree::load(){
    for (int i = 0; i < mainVec.size(); ++i){
        node* n = new node;
        n->index = i;
        for (int j = 0; j < mainVec[i].size(); ++j)
            n->s += mainVec[i][j];
        insertNode(root, n);
    }
    printTree(root);
    return;
}

I'd like load to fill up the tree at root (root is a private node pointer node* root), but every time insertNode exits root is still a null pointer. Could someone point out my stupid mistake?

Filip Roséen · Accepted Answer · 2012-03-20 03:49:48Z

1

You'll need to make parameter r passed as a reference to be able to change root from inside the function insertNode.

See the below:

void Btree::insertNode(node*& r, node* newNode) {
   ...
}

answered Mar 20, 2012 at 3:49

Filip Roséen

64.2k20 gold badges153 silver badges201 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Pepe · Accepted Answer · 2012-03-20 03:49:08Z

1

You need to pass root by reference.

answered Mar 20, 2012 at 3:49

Pepe

6,4805 gold badges29 silver badges29 bronze badges

Collectives™ on Stack Overflow

Binary Tree Insertion Pointer Issue

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related