Skip to content

Commit d24186f

Browse files
sebastianbergmannsebastianbergmann
committed
Simlify Psalm configuration
1 parent 68a57a1 commit d24186f

File tree

2 files changed

+99
-43
lines changed

2 files changed

+99
-43
lines changed

‎.psalm/baseline.xml‎

Lines changed: 96 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,10 +4,30 @@
44
<ArgumentTypeCoercion occurrences="1">
55
<code>$unit[0]</code>
66
</ArgumentTypeCoercion>
7+
<DocblockTypeContradiction occurrences="2">
8+
<code>!\is_array($linesToBeCovered) &amp;&amp; $linesToBeCovered !== false</code>
9+
<code>$id === null</code>
10+
</DocblockTypeContradiction>
11+
<InternalMethod occurrences="5">
12+
<code>getSize</code>
13+
<code>getName</code>
14+
<code>getName</code>
15+
<code>isMedium</code>
16+
<code>isLarge</code>
17+
</InternalMethod>
718
<PossiblyNullPropertyAssignmentValue occurrences="2">
819
<code>null</code>
920
<code>null</code>
1021
</PossiblyNullPropertyAssignmentValue>
22+
<PropertyNotSetInConstructor occurrences="1">
23+
<code>$currentId</code>
24+
</PropertyNotSetInConstructor>
25+
<RedundantConditionGivenDocblockType occurrences="1">
26+
<code>\is_array($linesToBeCovered)</code>
27+
</RedundantConditionGivenDocblockType>
28+
<UnresolvableInclude occurrences="1">
29+
<code>include_once $file</code>
30+
</UnresolvableInclude>
1131
</file>
1232
<file src="src/Driver/PcovDriver.php">
1333
<UndefinedConstant occurrences="1">
@@ -36,10 +56,27 @@
3656
<code>\XDEBUG_CC_BRANCH_CHECK</code>
3757
</UndefinedConstant>
3858
</file>
59+
<file src="src/Filter.php">
60+
<InvalidDocblockParamName occurrences="1">
61+
<code>$files</code>
62+
</InvalidDocblockParamName>
63+
</file>
3964
<file src="src/Node/AbstractNode.php">
65+
<DocblockTypeContradiction occurrences="5">
66+
<code>$this-&gt;id === null</code>
67+
<code>$this-&gt;pathAsString === null</code>
68+
<code>$this-&gt;parent === null</code>
69+
<code>$this-&gt;pathAsArray === null</code>
70+
<code>$this-&gt;parent === null</code>
71+
</DocblockTypeContradiction>
4072
<PossiblyNullPropertyAssignmentValue occurrences="1">
4173
<code>$parent</code>
4274
</PossiblyNullPropertyAssignmentValue>
75+
<PropertyNotSetInConstructor occurrences="3">
76+
<code>$pathAsString</code>
77+
<code>$pathAsArray</code>
78+
<code>$id</code>
79+
</PropertyNotSetInConstructor>
4380
</file>
4481
<file src="src/Node/Builder.php">
4582
<EmptyArrayAccess occurrences="1">
@@ -52,23 +89,56 @@
5289
</PossiblyInvalidArgument>
5390
</file>
5491
<file src="src/Node/Directory.php">
92+
<DocblockTypeContradiction occurrences="4">
93+
<code>$this-&gt;classes === null</code>
94+
<code>$this-&gt;traits === null</code>
95+
<code>$this-&gt;functions === null</code>
96+
<code>$this-&gt;linesOfCode === null</code>
97+
</DocblockTypeContradiction>
98+
<PropertyNotSetInConstructor occurrences="4">
99+
<code>$classes</code>
100+
<code>$traits</code>
101+
<code>$functions</code>
102+
<code>$linesOfCode</code>
103+
</PropertyNotSetInConstructor>
55104
<PropertyTypeCoercion occurrences="2">
56105
<code>$this-&gt;directories</code>
57106
<code>$this-&gt;files</code>
58107
</PropertyTypeCoercion>
59108
</file>
60109
<file src="src/Node/File.php">
110+
<DocblockTypeContradiction occurrences="5">
111+
<code>$this-&gt;numClasses === null</code>
112+
<code>$this-&gt;numTraits === null</code>
113+
<code>$this-&gt;numMethods === null</code>
114+
<code>$this-&gt;numTestedMethods === null</code>
115+
<code>$this-&gt;numTestedFunctions === null</code>
116+
</DocblockTypeContradiction>
61117
<InvalidPropertyAssignmentValue occurrences="4">
62118
<code>$this-&gt;codeUnitsByLine</code>
63119
<code>$this-&gt;codeUnitsByLine</code>
64120
<code>$this-&gt;codeUnitsByLine</code>
65121
<code>$this-&gt;codeUnitsByLine</code>
66122
</InvalidPropertyAssignmentValue>
123+
<MissingClosureParamType occurrences="2">
124+
<code>$branch</code>
125+
<code>$path</code>
126+
</MissingClosureParamType>
127+
<PropertyNotSetInConstructor occurrences="5">
128+
<code>$numClasses</code>
129+
<code>$numTraits</code>
130+
<code>$numMethods</code>
131+
<code>$numTestedMethods</code>
132+
<code>$numTestedFunctions</code>
133+
</PropertyNotSetInConstructor>
67134
</file>
68135
<file src="src/Node/Iterator.php">
69136
<ArgumentTypeCoercion occurrences="1">
70137
<code>$this-&gt;nodes[$this-&gt;position]</code>
71138
</ArgumentTypeCoercion>
139+
<PropertyNotSetInConstructor occurrences="1">
140+
<code>$position</code>
141+
</PropertyNotSetInConstructor>
72142
</file>
73143
<file src="src/RawCodeCoverageData.php">
74144
<PossiblyUndefinedMethod occurrences="1">
@@ -89,6 +159,12 @@
89159
<code>replaceChild</code>
90160
</PossiblyNullReference>
91161
</file>
162+
<file src="src/Report/Xml/Facade.php">
163+
<PropertyNotSetInConstructor occurrences="2">
164+
<code>$target</code>
165+
<code>$project</code>
166+
</PropertyNotSetInConstructor>
167+
</file>
92168
<file src="src/Report/Xml/File.php">
93169
<ArgumentTypeCoercion occurrences="1">
94170
<code>$totalsContainer</code>
@@ -104,6 +180,18 @@
104180
<PossiblyNullPropertyAssignmentValue occurrences="1">
105181
<code>$context-&gt;ownerDocument</code>
106182
</PossiblyNullPropertyAssignmentValue>
183+
<PropertyNotSetInConstructor occurrences="2">
184+
<code>$dom</code>
185+
<code>$contextNode</code>
186+
</PropertyNotSetInConstructor>
187+
</file>
188+
<file src="src/Report/Xml/Report.php">
189+
<MissingParamType occurrences="4">
190+
<code>$name</code>
191+
<code>$name</code>
192+
<code>$name</code>
193+
<code>$name</code>
194+
</MissingParamType>
107195
</file>
108196
<file src="src/Report/Xml/Source.php">
109197
<PossiblyNullArgument occurrences="1">
@@ -115,6 +203,9 @@
115203
</PossiblyNullReference>
116204
</file>
117205
<file src="src/Report/Xml/Tests.php">
206+
<MissingPropertyType occurrences="1">
207+
<code>$codeMap</code>
208+
</MissingPropertyType>
118209
<PossiblyNullReference occurrences="1">
119210
<code>createElementNS</code>
120211
</PossiblyNullReference>
@@ -131,4 +222,9 @@
131222
<code>createElementNS</code>
132223
</PossiblyNullReference>
133224
</file>
225+
<file src="src/Version.php">
226+
<DocblockTypeContradiction occurrences="1">
227+
<code>self::$version === null</code>
228+
</DocblockTypeContradiction>
229+
</file>
134230
</files>

‎.psalm/config.xml‎

Lines changed: 3 additions & 43 deletions
Original file line numberDiff line numberDiff line change
@@ -1,56 +1,16 @@
11
<?xml version="1.0"?>
22
<psalm
3-
totallyTyped="false"
4-
cacheDirectory=".psalm/cache"
5-
errorBaseline=".psalm/baseline.xml"
63
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
74
xmlns="https://getpsalm.org/schema/config"
85
xsi:schemaLocation="https://getpsalm.org/schema/config vendor/vimeo/psalm/config.xsd"
6+
cacheDirectory=".psalm/cache"
7+
errorBaseline=".psalm/baseline.xml"
8+
totallyTyped="false"
99
>
1010
<projectFiles>
1111
<directory name="src" />
1212
<ignoreFiles>
1313
<directory name="vendor" />
1414
</ignoreFiles>
1515
</projectFiles>
16-
17-
<issueHandlers>
18-
<LessSpecificReturnType errorLevel="info" />
19-
20-
<!-- level 3 issues - slightly lazy code writing, but provably low false-negatives -->
21-
22-
<DeprecatedMethod errorLevel="info" />
23-
<DeprecatedProperty errorLevel="info" />
24-
<DeprecatedClass errorLevel="info" />
25-
<DeprecatedConstant errorLevel="info" />
26-
<DeprecatedFunction errorLevel="info" />
27-
<DeprecatedInterface errorLevel="info" />
28-
<DeprecatedTrait errorLevel="info" />
29-
30-
<InternalMethod errorLevel="info" />
31-
<InternalProperty errorLevel="info" />
32-
<InternalClass errorLevel="info" />
33-
34-
<MissingClosureReturnType errorLevel="info" />
35-
<MissingReturnType errorLevel="info" />
36-
<MissingPropertyType errorLevel="info" />
37-
<InvalidDocblock errorLevel="info" />
38-
<MisplacedRequiredParam errorLevel="info" />
39-
40-
<PropertyNotSetInConstructor errorLevel="info" />
41-
<MissingConstructor errorLevel="info" />
42-
<MissingClosureParamType errorLevel="info" />
43-
<MissingParamType errorLevel="info" />
44-
45-
<RedundantCondition errorLevel="info" />
46-
47-
<DocblockTypeContradiction errorLevel="info" />
48-
<RedundantConditionGivenDocblockType errorLevel="info" />
49-
50-
<UnresolvableInclude errorLevel="info" />
51-
52-
<RawObjectIteration errorLevel="info" />
53-
54-
<InvalidStringClass errorLevel="info" />
55-
</issueHandlers>
5616
</psalm>

0 commit comments

Comments
 (0)