tests for sets and maps

Author: amejiarosario

lib/data-structures/hash-maps/hash-map.js

@@ -108,11 +108,11 @@ class HashMap {
     for (let entryIndex = 0; entryIndex < values.length; entryIndex++) {
       const entry = values[entryIndex];
       if(entry.key === key) {
-        return {bucketIndex, entryIndex};
+        return {bucketIndex, entryIndex, keyIndex: entry.keyIndex};
       }
     }
 
-    return {bucketIndex, entryIndex: undefined};
+    return {bucketIndex};
   }
 
   /**

lib/data-structures/hash-maps/hash-map.spec.js

@@ -35,9 +35,21 @@ describe('without collisions', () => {
     hashMap.set('test', 'uno');
     expect(hashMap.has('test')).toBe(true);
   });
+
+  it('should update keys on deletes', () => {
+    hashMap.set('Despacito', 'Luis Fonsi');
+    hashMap.set('Bailando', 'Enrique Iglesias');
+    hashMap.set('Dura', 'Daddy Yankee');
+
+    expect(hashMap.delete('Bailando')).toBe(true);
+    expect(hashMap.delete('Bailando')).toBe(false);
+    expect(hashMap.get('Bailando')).toBe(undefined);
+
+    expect(hashMap.keys.map(k => k.content)).toEqual(["Despacito", , "Dura"]);
+  });
 });
 
-describe('with many collisions', () => {
+describe('with many values (and collisions)', () => {
   let hashMap;
 
   beforeEach(() => {

lib/data-structures/sets/set.js

@@ -22,6 +22,15 @@ class MySet {
   delete(value) {
     return this.map.delete(value);
   }
+
+  entries() {
+    return this.map.keys.reduce((acc, key) => {
+      if(key !== undefined) {
+        acc.push(key.content);
+      }
+      return acc
+    }, []);
+  }
 }
 
 module.exports = MySet;

lib/data-structures/sets/set.spec.js

@@ -0,0 +1,56 @@
+const MySet = require('./set');
+
+describe('Set', function () {
+  let set;
+
+  beforeEach(() => {
+    set = new MySet();
+  });
+
+  it('should set size and has', () => {
+    expect(set.size).toBe(0);
+    expect(set.has('uno')).toBe(false);
+
+    set.add('uno');
+
+    expect(set.has('uno')).toBe(true);
+    expect(set.size).toBe(1);
+  });
+
+  it('should not allow duplicates', () => {
+    set.add('uno');
+    set.add('one');
+    set.add('uno');
+
+    expect(set.size).toBe(2);
+    expect(set.has('uno')).toBe(true);
+    expect(set.has('one')).toBe(true);
+  });
+
+  it('should delete items', () => {
+    expect(set.delete('uno')).toBe(false);
+
+    set.add('uno');
+
+    expect(set.delete('uno')).toBe(true);
+    expect(set.size).toBe(0);
+  });
+
+  it('should return entries', () => {
+    set.add(1);
+    set.add(2);
+    set.add(3);
+    expect(set.entries()).toEqual([1,2,3]);
+  });
+
+  it('should return entries', () => {
+    set.add(0);
+    set.add(1);
+    set.add(2);
+    set.add(3);
+
+    expect(set.delete(2)).toBe(true);
+
+    expect(set.entries()).toEqual([0,1,3]);
+  });
+});