refactored removeLast

Author: amejiarosario

lib/data-structures/linked-lists/linked-list.js

@@ -36,23 +36,19 @@ class LinkedList {
 
   removeLast() { // similar to Array.pop
     const current = this.root;
+    let target;
 
-    if(!current || !current.next) {
-      const target = current;
-      this.root = null;
-      if(target) {
-        return target.value;
+    if(current && current.next) {
+      while(current && current.next && current.next.next) {
+        current = current.next;
       }
-      return;
-    }
-
-    while(current && current.next && current.next.next) {
-      current = current.next;
+      target = current.next;
+      current.next = null;
+    } else {
+      this.root = null;
+      target = current;
     }
 
-    const target = current.next;
-    current.next = null;
-
     if(target) {
       return target.value;
     }

lib/data-structures/linked-lists/linked-list.spec.js

@@ -35,6 +35,7 @@ describe('LinkedList', function () {
 
       expect(linkedList.removeFirst()).toBe('b');
       expect(linkedList.removeFirst()).toBe(undefined);
+      expect(linkedList.removeFirst()).toBe(undefined);
     });
   });
 
@@ -65,6 +66,7 @@ describe('LinkedList', function () {
 
       expect(linkedList.removeLast()).toBe('a');
       expect(linkedList.removeLast()).toBe(undefined);
+      expect(linkedList.removeLast()).toBe(undefined);
     });
   });
 });