Skip to content

Commit aeb0e4f

Browse files
amejiarosarioamejiarosario
committed
some eslint fixes
1 parent b6d1808 commit aeb0e4f

File tree

17 files changed

+123
-128
lines changed

17 files changed

+123
-128
lines changed

‎src/data-structures/hash-maps/hash-map-1.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22
* Naïve HashMap implementation
33
*/
44
class HashMap {
5-
65
/**
76
* Initialize array that holds the values. Default is size 1,000
87
* @param {number} initialCapacity
@@ -52,6 +51,7 @@ class HashMap {
5251

5352
// Usage:
5453
const assert = require('assert');
54+
5555
const hashMap = new HashMap();
5656

5757
hashMap.set('cat', 2);
@@ -68,4 +68,4 @@ console.log(hashMap.buckets);
6868
assert.equal(hashMap.get('art'), 8); // this one is ok
6969
assert.equal(hashMap.get('cat'), 8); // got overwritten by art 😱
7070
assert.equal(hashMap.get('rat'), 8); // got overwritten by art 😱
71-
assert.equal(hashMap.get('dog'), 8); // got overwritten by art 😱
71+
assert.equal(hashMap.get('dog'), 8); // got overwritten by art 😱

‎src/data-structures/hash-maps/hash-map-2.js‎

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22
* Hash Map data structure implementation
33
*/
44
class HashMap {
5-
65
/**
76
* Initialize array that holds the values. Default is size 1,000
87
* @param {number} initialCapacity
@@ -19,11 +18,11 @@ class HashMap {
1918
*/
2019
set(key, value) {
2120
const bucketIndex = this.getIndex(key);
22-
if(this.buckets[bucketIndex]) {
23-
this.buckets[bucketIndex].push({key, value});
24-
if(this.buckets[bucketIndex].length > 1) { this.collisions++; }
21+
if (this.buckets[bucketIndex]) {
22+
this.buckets[bucketIndex].push({ key, value });
23+
if (this.buckets[bucketIndex].length > 1) { this.collisions++; }
2524
} else {
26-
this.buckets[bucketIndex] = [{key, value}];
25+
this.buckets[bucketIndex] = [{ key, value }];
2726
}
2827
return this;
2928
}
@@ -36,8 +35,8 @@ class HashMap {
3635
const bucketIndex = this.getIndex(key);
3736
for (let arrayIndex = 0; arrayIndex < this.buckets[bucketIndex].length; arrayIndex++) {
3837
const entry = this.buckets[bucketIndex][arrayIndex];
39-
if(entry.key === key) {
40-
return entry.value
38+
if (entry.key === key) {
39+
return entry.value;
4140
}
4241
}
4342
}
@@ -72,6 +71,7 @@ class HashMap {
7271

7372
// Usage:
7473
const assert = require('assert');
74+
7575
const hashMap = new HashMap();
7676

7777
hashMap.set('cat', 2);
@@ -125,4 +125,4 @@ hashMapSize100.set('dog', 1);
125125
hashMapSize100.set('art', 8);
126126

127127
console.log('collisions: ', hashMapSize100.collisions);
128-
console.log('hashMapSize100\n', hashMapSize100.buckets);
128+
console.log('hashMapSize100\n', hashMapSize100.buckets);

‎src/data-structures/hash-maps/hash-map-3.js‎

Lines changed: 23 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
* @author Adrian Mejia <me AT adrianmejia.com>
44
*/
55
class HashMap {
6-
76
/**
87
* Initialize array that holds the values. Default is size 1,000
98
* @param {number} initialCapacity initial size of the array
@@ -50,23 +49,23 @@ class HashMap {
5049
* @param {any} value
5150
*/
5251
set(key, value) {
53-
const {bucketIndex, entryIndex} = this._getIndexes(key);
52+
const { bucketIndex, entryIndex } = this._getIndexes(key);
5453

55-
if(entryIndex === undefined) {
54+
if (entryIndex === undefined) {
5655
// initialize array and save key/value
57-
const keyIndex = this.keys.push({content: key}) - 1; // keep track of the key index
56+
const keyIndex = this.keys.push({ content: key }) - 1; // keep track of the key index
5857
this.buckets[bucketIndex] = this.buckets[bucketIndex] || [];
59-
this.buckets[bucketIndex].push({key, value, keyIndex});
58+
this.buckets[bucketIndex].push({ key, value, keyIndex });
6059
this.size++;
6160
// Optional: keep count of collisions
62-
if(this.buckets[bucketIndex].length > 1) { this.collisions++; }
61+
if (this.buckets[bucketIndex].length > 1) { this.collisions++; }
6362
} else {
6463
// override existing value
6564
this.buckets[bucketIndex][entryIndex].value = value;
6665
}
6766

6867
// check if a rehash is due
69-
if(this.loadFactor > 0 && this.getLoadFactor() > this.loadFactor) {
68+
if (this.loadFactor > 0 && this.getLoadFactor() > this.loadFactor) {
7069
this.rehash(this.buckets.length * 2);
7170
}
7271

@@ -79,9 +78,9 @@ class HashMap {
7978
* @param {any} key
8079
*/
8180
get(key) {
82-
const {bucketIndex, entryIndex} = this._getIndexes(key);
81+
const { bucketIndex, entryIndex } = this._getIndexes(key);
8382

84-
if(entryIndex === undefined) {
83+
if (entryIndex === undefined) {
8584
return;
8685
}
8786

@@ -107,22 +106,22 @@ class HashMap {
107106

108107
for (let entryIndex = 0; entryIndex < values.length; entryIndex++) {
109108
const entry = values[entryIndex];
110-
if(entry.key === key) {
111-
return {bucketIndex, entryIndex};
109+
if (entry.key === key) {
110+
return { bucketIndex, entryIndex };
112111
}
113112
}
114113

115-
return {bucketIndex};
114+
return { bucketIndex };
116115
}
117116

118117
/**
119118
* Returns true if an element in the Map object existed and has been removed, or false if the element does not exist.
120119
* @param {any} key
121120
*/
122121
delete(key) {
123-
const {bucketIndex, entryIndex, keyIndex} = this._getIndexes(key);
122+
const { bucketIndex, entryIndex, keyIndex } = this._getIndexes(key);
124123

125-
if(entryIndex === undefined) {
124+
if (entryIndex === undefined) {
126125
return false;
127126
}
128127

@@ -140,8 +139,8 @@ class HashMap {
140139
rehash(newCapacity) {
141140
const newMap = new HashMap(newCapacity);
142141

143-
this.keys.forEach(key => {
144-
if(key) {
142+
this.keys.forEach((key) => {
143+
if (key) {
145144
newMap.set(key.content, this.get(key.content));
146145
}
147146
});
@@ -167,6 +166,7 @@ const hashMap = new HashMap(1);
167166
// const hashMap = new Map();
168167

169168
const assert = require('assert');
169+
170170
assert.equal(hashMap.size, 0);
171171
hashMap.set('cat', 2);
172172
assert.equal(hashMap.size, 1);
@@ -213,32 +213,32 @@ assert.equal(hashMap.getLoadFactor(), 5);
213213
hashMap.rehash(1000);
214214
console.log(hashMap.collisions);
215215
console.log(hashMap.buckets);
216-
assert.equal(hashMap.getLoadFactor(), 5/1000);
216+
assert.equal(hashMap.getLoadFactor(), 5 / 1000);
217217

218218
// automatic rehashing based on loadFactor
219219
const dynamicMap = new HashMap(2, 0.75);
220220

221221
dynamicMap.set('uno', 1);
222222
assert.equal(dynamicMap.buckets.length, 2);
223-
assert.equal(dynamicMap.getLoadFactor(), 1/2);
223+
assert.equal(dynamicMap.getLoadFactor(), 1 / 2);
224224
console.log(hashMap.collisions);
225225

226226
dynamicMap.set('dos', 2);
227227
assert.equal(dynamicMap.buckets.length, 4); // <-- rehash took place
228-
assert.equal(dynamicMap.getLoadFactor(), 1/2);
228+
assert.equal(dynamicMap.getLoadFactor(), 1 / 2);
229229
console.log(hashMap.collisions);
230230

231231
dynamicMap.set('tres', 3);
232232
assert.equal(dynamicMap.buckets.length, 4); // <-- no rehash
233-
assert.equal(dynamicMap.getLoadFactor(), 3/4);
233+
assert.equal(dynamicMap.getLoadFactor(), 3 / 4);
234234
console.log(hashMap.collisions);
235235

236236
dynamicMap.set('cuatro', 4);
237237
assert.equal(dynamicMap.buckets.length, 8); // <-- rehash took place
238-
assert.equal(dynamicMap.getLoadFactor(), 4/8);
238+
assert.equal(dynamicMap.getLoadFactor(), 4 / 8);
239239
console.log(hashMap.collisions);
240240

241241
dynamicMap.set('cinco', 5);
242242
assert.equal(dynamicMap.buckets.length, 8); // <-- no rehash
243-
assert.equal(dynamicMap.getLoadFactor(), 5/8);
244-
console.log(hashMap.collisions);
243+
assert.equal(dynamicMap.getLoadFactor(), 5 / 8);
244+
console.log(hashMap.collisions);

‎src/data-structures/hash-maps/hash-map.js‎

Lines changed: 14 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
* @author Adrian Mejia <me AT adrianmejia.com>
44
*/
55
class HashMap {
6-
76
/**
87
* Initialize array that holds the values. Default is size 16
98
* @param {number} initialCapacity initial size of the array
@@ -50,23 +49,23 @@ class HashMap {
5049
* @param {any} value
5150
*/
5251
set(key, value) {
53-
const {bucketIndex, entryIndex} = this._getIndexes(key);
52+
const { bucketIndex, entryIndex } = this._getIndexes(key);
5453

55-
if(entryIndex === undefined) {
54+
if (entryIndex === undefined) {
5655
// initialize array and save key/value
57-
const keyIndex = this.keys.push({content: key}) - 1; // keep track of the key index
56+
const keyIndex = this.keys.push({ content: key }) - 1; // keep track of the key index
5857
this.buckets[bucketIndex] = this.buckets[bucketIndex] || [];
59-
this.buckets[bucketIndex].push({key, value, keyIndex});
58+
this.buckets[bucketIndex].push({ key, value, keyIndex });
6059
this.size++;
6160
// Optional: keep count of collisions
62-
if(this.buckets[bucketIndex].length > 1) { this.collisions++; }
61+
if (this.buckets[bucketIndex].length > 1) { this.collisions++; }
6362
} else {
6463
// override existing value
6564
this.buckets[bucketIndex][entryIndex].value = value;
6665
}
6766

6867
// check if a rehash is due
69-
if(this.loadFactor > 0 && this.getLoadFactor() > this.loadFactor) {
68+
if (this.loadFactor > 0 && this.getLoadFactor() > this.loadFactor) {
7069
this.rehash(this.buckets.length * 2);
7170
}
7271

@@ -79,9 +78,9 @@ class HashMap {
7978
* @param {any} key
8079
*/
8180
get(key) {
82-
const {bucketIndex, entryIndex} = this._getIndexes(key);
81+
const { bucketIndex, entryIndex } = this._getIndexes(key);
8382

84-
if(entryIndex === undefined) {
83+
if (entryIndex === undefined) {
8584
return;
8685
}
8786

@@ -107,22 +106,22 @@ class HashMap {
107106

108107
for (let entryIndex = 0; entryIndex < values.length; entryIndex++) {
109108
const entry = values[entryIndex];
110-
if(entry.key === key) {
111-
return {bucketIndex, entryIndex, keyIndex: entry.keyIndex};
109+
if (entry.key === key) {
110+
return { bucketIndex, entryIndex, keyIndex: entry.keyIndex };
112111
}
113112
}
114113

115-
return {bucketIndex};
114+
return { bucketIndex };
116115
}
117116

118117
/**
119118
* Returns true if an element in the Map object existed and has been removed, or false if the element does not exist.
120119
* @param {any} key
121120
*/
122121
delete(key) {
123-
const {bucketIndex, entryIndex, keyIndex} = this._getIndexes(key);
122+
const { bucketIndex, entryIndex, keyIndex } = this._getIndexes(key);
124123

125-
if(entryIndex === undefined) {
124+
if (entryIndex === undefined) {
126125
return false;
127126
}
128127

@@ -140,7 +139,7 @@ class HashMap {
140139
rehash(newCapacity) {
141140
const newMap = new HashMap(newCapacity);
142141

143-
this.keys.forEach(key => {
142+
this.keys.forEach((key) => {
144143
newMap.set(key.content, this.get(key.content));
145144
});
146145

‎src/data-structures/hash-maps/hash-map.spec.js‎

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -18,19 +18,19 @@ describe('without collisions', () => {
1818
expect(hashMap.getLoadFactor()).toBe(0);
1919
expect(hashMap.size).toBe(0);
2020
hashMap.set('test', 'one');
21-
expect(hashMap.getLoadFactor()).toBe(1/16);
21+
expect(hashMap.getLoadFactor()).toBe(1 / 16);
2222
expect(hashMap.size).toBe(1);
2323
});
2424

25-
it('should overwrite values and keep same size', () =>{
25+
it('should overwrite values and keep same size', () => {
2626
hashMap.set('test', 'uno');
2727
expect(hashMap.get('test')).toBe('uno');
2828
hashMap.set('test', 'dos');
2929
expect(hashMap.get('test')).toBe('dos');
3030
expect(hashMap.size).toBe(1);
3131
});
3232

33-
it('should return with has', () =>{
33+
it('should return with has', () => {
3434
expect(hashMap.has('test')).toBe(false);
3535
hashMap.set('test', 'uno');
3636
expect(hashMap.has('test')).toBe(true);
@@ -45,7 +45,7 @@ describe('without collisions', () => {
4545
expect(hashMap.delete('Bailando')).toBe(false);
4646
expect(hashMap.get('Bailando')).toBe(undefined);
4747

48-
expect(hashMap.keys.map(k => k.content)).toEqual(["Despacito", , "Dura"]);
48+
expect(hashMap.keys.map(k => k.content)).toEqual(['Despacito', , 'Dura']);
4949
});
5050
});
5151

@@ -76,19 +76,19 @@ describe('with many values (and collisions)', () => {
7676
expect(hashMap.getLoadFactor()).toBe(4);
7777
expect(hashMap.size).toBe(8);
7878
hashMap.set('test', 'one');
79-
expect(hashMap.getLoadFactor()).toBe(9/2);
79+
expect(hashMap.getLoadFactor()).toBe(9 / 2);
8080
expect(hashMap.size).toBe(9);
8181
});
8282

83-
it('should overwrite values and keep same size', () =>{
83+
it('should overwrite values and keep same size', () => {
8484
hashMap.set('test', 'uno');
8585
expect(hashMap.get('test')).toBe('uno');
8686
hashMap.set('test', 'dos');
8787
expect(hashMap.get('test')).toBe('dos');
8888
expect(hashMap.size).toBe(9);
8989
});
9090

91-
it('should return with has', () =>{
91+
it('should return with has', () => {
9292
expect(hashMap.has('test')).toBe(false);
9393
hashMap.set('test', 'uno');
9494
expect(hashMap.has('test')).toBe(true);
@@ -115,18 +115,18 @@ describe('#rehash', () => {
115115
});
116116

117117
it('should rehash after 12 items by default', () => {
118-
expect(hashMap.getLoadFactor()).toBe(11/16);
118+
expect(hashMap.getLoadFactor()).toBe(11 / 16);
119119
expect(hashMap.buckets.length).toBe(16);
120120
hashMap.set('Alone', 'Alan Walker');
121121
expect(hashMap.getLoadFactor()).toBe(0.75);
122122

123123
hashMap.set('Levels', 'Avicii');
124124

125-
expect(hashMap.getLoadFactor()).toBe(13/32);
125+
expect(hashMap.getLoadFactor()).toBe(13 / 32);
126126
expect(hashMap.buckets.length).toBe(32);
127127

128128
expect(hashMap.get('Dura')).toBe('Daddy Yankee');
129129
expect(hashMap.get('Bailando')).toBe('Enrique Iglesias');
130130
expect(hashMap.get('Levels')).toBe('Avicii');
131131
});
132-
});
132+
});

0 commit comments

Comments
 (0)