remove unsued code

Author: amejiarosario

lib/data-structures/hash-maps/hash-map.js

@@ -141,9 +141,7 @@ class HashMap {
     const newMap = new HashMap(newCapacity);
 
     this.keys.forEach(key => {
-      if(key) {
-        newMap.set(key.content, this.get(key.content));
-      }
+      newMap.set(key.content, this.get(key.content));
     });
 
     // update bucket

lib/data-structures/linked-lists/linked-list.js

@@ -35,7 +35,7 @@ class LinkedList {
   }
 
   removeLast() { // similar to Array.pop
-    const current = this.root;
+    let current = this.root;
     let target;
 
     if(current && current.next) {

lib/data-structures/linked-lists/linked-list.spec.js

@@ -16,9 +16,11 @@ describe('LinkedList', function () {
     it('should link values', () => {
       linkedList.addLast('a');
       linkedList.addLast('b');
+      linkedList.addLast('c');
 
       expect(linkedList.root.value).toBe('a');
       expect(linkedList.root.next.value).toBe('b');
+      expect(linkedList.root.next.next.value).toBe('c');
     });
   });
 
@@ -57,9 +59,11 @@ describe('LinkedList', function () {
     beforeEach(() => {
       linkedList.addLast('a');
       linkedList.addLast('b');
+      linkedList.addLast('c');
     });
 
     it('should remove first item', () => {
+      expect(linkedList.removeLast()).toBe('c');
       expect(linkedList.removeLast()).toBe('b');
       expect(linkedList.root.value).toBe('a');
       expect(linkedList.root.next).toBe(null);

lib/data-structures/sets/set.js

@@ -25,32 +25,30 @@ class MySet {
 
   entries() {
     return this.hashMap.keys.reduce((acc, key) => {
-      if(key !== undefined) {
-        acc.push(key.content);
-      }
-      return acc
+      acc.push(key.content);
+      return acc;
     }, []);
   }
 }
 
 module.exports = MySet;
 
-const assert = require('assert');
-// const set = new Set();
-const set = new MySet();
+// const assert = require('assert');
+// // const set = new Set();
+// const set = new MySet();
 
-set.add('one');
-set.add('uno');
-set.add('one');
+// set.add('one');
+// set.add('uno');
+// set.add('one');
 
-assert.equal(set.has('one'), true);
-assert.equal(set.has('dos'), false);
+// assert.equal(set.has('one'), true);
+// assert.equal(set.has('dos'), false);
 
-assert.equal(set.size, 2);
-// assert.deepEqual(Array.from(set), ['one', 'uno']);
+// assert.equal(set.size, 2);
+// // assert.deepEqual(Array.from(set), ['one', 'uno']);
 
-assert.equal(set.delete('one'), true);
-assert.equal(set.delete('one'), false);
-assert.equal(set.has('one'), false);
-assert.equal(set.size, 1);
+// assert.equal(set.delete('one'), true);
+// assert.equal(set.delete('one'), false);
+// assert.equal(set.has('one'), false);
+// assert.equal(set.size, 1);
 

lib/data-structures/sets/set.spec.js

@@ -43,15 +43,16 @@ describe('Set', function () {
     expect(set.entries()).toEqual([1,2,3]);
   });
 
-  it('should return entries', () => {
+  it('should return entries wihout holes', () => {
     set.add(0);
     set.add(1);
     set.add(2);
     set.add(3);
 
     expect(set.delete(2)).toBe(true);
+    expect(set.delete(0)).toBe(true);
 
-    expect(set.entries()).toEqual([0,1,3]);
-    expect(set.size).toBe(3);
+    expect(set.entries()).toEqual([1,3]);
+    expect(set.size).toBe(2);
   });
 });

package.json

@@ -18,7 +18,7 @@
   },
   "scripts": {
     "test": "jest lib/data-structures # jest # mocha src/**/*spec.js # jasmine JASMINE_CONFIG_PATH=jasmine.json # node jasmine-runner.js",
-    "watch": "jest lib/data-structures --watch",
+    "watch": "jest lib/data-structures --watch --coverage",
     "coverage": "jest lib/data-structures --coverage && open coverage/lcov-report/index.html"
   },
   "keywords": [],